Disable background_threads support on windows

tikv · Aug 4, 2024 · 85913f9 · 85913f9
1 parent c20fc53
commit 85913f9
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -19,7 +19,7 @@ jobs:
         include:
           - name: x86_64-pc-windows-msvc
             target: x86_64-pc-windows-msvc
-            nobgt: 0
+            nobgt: 1
             no_tests: 1
             tag: windows-latest
           - name: x86_64-apple-darwin

diff --git a/jemalloc-ctl/src/macros.rs b/jemalloc-ctl/src/macros.rs
@@ -69,7 +69,7 @@ macro_rules! r {
                 match stringify!($id) {
                     "background_thread" |
                     "max_background_threads"
-                    if cfg!(target_os = "macos") => return,
+                    if cfg!(target_os = "macos") || cfg!(windows) => return,
                     _ => (),
                 }
 
@@ -117,7 +117,7 @@ macro_rules! w {
                 match stringify!($id) {
                     "background_thread" |
                     "max_background_threads"
-                        if cfg!(target_os = "macos") => return,
+                        if cfg!(target_os = "macos") || cfg!(windows) => return,
                     _ => (),
                 }
 
@@ -167,7 +167,7 @@ macro_rules! u {
                 match stringify!($id) {
                     "background_thread" |
                     "max_background_threads"
-                        if cfg!(target_os = "macos") => return,
+                        if cfg!(target_os = "macos") || cfg!(windows) => return,
                     _ => (),
                 }
 

diff --git a/jemalloc-sys/src/env.rs b/jemalloc-sys/src/env.rs
@@ -12,7 +12,7 @@ pub static UNSUPPORTED_TARGETS: &[&str] = &[
 pub static UNTESTED_TARGETS: &[&str] = &["openbsd", "msvc"];
 
 /// `jemalloc`'s background_thread support is known not to work on these targets:
-pub static NO_BG_THREAD_TARGETS: &[&str] = &["musl"];
+pub static NO_BG_THREAD_TARGETS: &[&str] = &["musl", "windows"];
 
 /// targets that don't support unprefixed `malloc`
 // “it was found that the `realpath` function in libc would allocate with libc malloc

diff --git a/jemallocator/tests/background_thread_enabled.rs b/jemallocator/tests/background_thread_enabled.rs
@@ -2,7 +2,7 @@
 //! library was compiled with background thread run-time support.
 #![cfg(feature = "background_threads_runtime_support")]
 #![cfg(not(feature = "unprefixed_malloc_on_supported_platforms"))]
-#![cfg(not(target_env = "musl"))]
+#![cfg(not(any(windows, target_env = "musl")))]
 
 use tikv_jemallocator::Jemalloc;