codec: check serialization result length #496
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grpc c core can only handle message that is not larger than 4GiB. Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
hicqu
previously approved these changes
Nov 24, 2020
hunterlxt
reviewed
Nov 24, 2020
src/codec.rs
Outdated
| t.write_to_vec(buf).unwrap() | ||
| pub fn ser<T: Message>(t: &T, buf: &mut Vec<u8>) -> Result<()> { | ||
| t.write_to_vec(buf)?; | ||
| if buf.len() <= u32::MAX as usize { |
There was a problem hiding this comment.
Add a comment to explain that the source of this number is from https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md
Signed-off-by: Jay Lee <[email protected]>
hunterlxt
previously approved these changes
Nov 24, 2020
|
The lint check is failed. |
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay <[email protected]>
Signed-off-by: Jay <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
BusyJay
force-pushed
the
fix-size-coredump
branch
from
8055cc5
to
1b25b2e
Compare
|
PTAL |
hunterlxt
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grpc c core can only handle message that is not larger than 4GiB.
This is a cherry-pick of #495.