Skip to content

Conversation

@pingyu
Copy link
Collaborator

@pingyu pingyu commented May 27, 2025

As title.

@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 27, 2025
Signed-off-by: Ping Yu <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 27, 2025
pingyu added 2 commits May 28, 2025 11:13
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
/// Placeholder for no error (taken away).
#[default]
#[error("No error")]
NoError,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are this enum value referenced?

Copy link
Collaborator Author

@pingyu pingyu May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In following block in src/store/error.rs:

impl<T: HasKeyErrors> HasKeyErrors for Result<T, Error> {
    fn key_errors(&mut self) -> Option<Vec<Error>> {
        match self {
            Ok(x) => x.key_errors(),
            Err(Error::MultipleKeyErrors(errs)) => Some(std::mem::take(errs)),
            Err(e) => Some(vec![std::mem::take(e)]),
        }
    }
}

The std::mem::take requires Default.

Signed-off-by: Ping Yu <[email protected]>
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 28, 2025

@iosmanthus: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 28, 2025

@coocood: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: coocood, iosmanthus

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pingyu pingyu merged commit ac95421 into tikv:cse May 28, 2025
6 of 7 checks passed
emmanuel-keller pushed a commit to surrealdb/tikv-client that referenced this pull request May 29, 2025
Signed-off-by: Ping Yu <[email protected]>
(cherry picked from commit ac95421)
emmanuel-keller pushed a commit to surrealdb/tikv-client that referenced this pull request May 29, 2025
Signed-off-by: Ping Yu <[email protected]>
(cherry picked from commit ac95421)
emmanuel-keller pushed a commit to surrealdb/tikv-client that referenced this pull request May 29, 2025
Signed-off-by: Ping Yu <[email protected]>
(cherry picked from commit ac95421)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants