-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vulnxscan: Add cve-bin-tool scanner #75
Draft
henrirosten
wants to merge
1
commit into
tiiuae:main
Choose a base branch
from
henrirosten:vulnxscan_add_cve_bin_tool
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrirosten
force-pushed
the
vulnxscan_add_cve_bin_tool
branch
from
June 29, 2023 06:17
e342ccd
to
f30739c
Compare
henrirosten
force-pushed
the
vulnxscan_add_cve_bin_tool
branch
from
August 9, 2023 08:43
f30739c
to
bc4ffb5
Compare
We decided to not merge this for now. The main problem is that cve-bin-tool reports way too many false positives. As an example, in a recent test run on a Ghaf target, cve-bin-tool reported the following vulnerabilities that were not reported by any other scanners:
We end-up with the following list of vulns:
Quick manual triage:
Clearly, there's something wrong with the way cve-bin-tool matches vulnerable components (versions). |
Adds cve-bin-tool scanner to vulnxscan Signed-off-by: Henri Rosten <[email protected]>
henrirosten
force-pushed
the
vulnxscan_add_cve_bin_tool
branch
from
August 11, 2023 11:35
bc4ffb5
to
7eee82c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds cve-bin-tool scanner to vulnxscan.
Why do we use cve-bin-tool fork instead of the upstream or the version in nixpkgs?
The main reason is, both the upstream and the nixpkgs versions require an older version of python packaging. This project (vulnxscan) also requires packaging, but it needs a newer version. This results a conflict in python dependencies. The cve-bin-tool fork we are using in this PR attempts to resolve the upstream cve-bin-tool python dependencies issues so that newer version of packaging can be used in cve-bin-tool. As soon as the issue is properly resoved upstream and in nixpkgs, we should change vulnxscan to also start using the cve-bin-tool version from nixpkgs.