Skip to content

Conversation

@arikimari
Copy link

@arikimari arikimari commented Jan 8, 2026

Summary

Remove default ddr configuration. Add function to return ddr configuration

Impact

Testing

@arikimari arikimari force-pushed the add-ddr-config branch 3 times, most recently from 51c996c to b1e583b Compare January 8, 2026 10:29
@arikimari arikimari requested a review from jlaitine January 8, 2026 11:10
@jlaitine
Copy link

jlaitine commented Jan 8, 2026

I'd suggest not adding the CONFIG flag here; it is a bit confusing since some configuration is always needed.

Instead, in nuttx / imx9_ddr_training.c, make a "struct dram_timing_info * weak_function imx9_ddr_config()", returning a pointer to the default structure and call it directly in the beginning of "imx9_dram_init" to initialize the "ptiming" variable there.

Then we (or any board) can simply add an own version of the imx9_ddr_config(), which returns a pointer to our own structure.

@arikimari arikimari force-pushed the add-ddr-config branch 2 times, most recently from 2736994 to dc7dad1 Compare January 12, 2026 14:25
Copy link

@jlaitine jlaitine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but perhaps add also the evk settings to the evk board with the same commit?

i.e.: The following should work

export PATH=$PATH:<path to compiler>
cd <path to nuttx>
./tools/configure.sh imx93-evk:bootloader
make

With this it would fail for the target, because there is no imx9_ddr_config function defined for the plain nuttx board.

When the imx9_ddr_config is also defined for the nuttx board, this commit can be upstreamed as well.

Also, please update the commit message (there is no longer the CONFIG_IMX9_DDR_CONFIG flag). Commit message should just describe that the default configuration is removed and ddr configuration is added to board instead.

@arikimari
Copy link
Author

imx93 EVK does not have CONFIG_IMX9_DDR_TRAINING set so there is no need for imx9_ddr_config

@jlaitine
Copy link

imx93-evk:bootloader configuration has it, it doesn't link with this commit, just try it.

@jlaitine
Copy link

Looks good, let's just fix the commit title&message and the style check error (missing blank line).

Remove default ddr config
Add imx9_ddr_config() function  to return default config

Signed-off-by: Ari Kimari <[email protected]>
@arikimari arikimari changed the title Add CONFIG_IMX9_DDR_CONFIG Modify default ddr config handling Jan 14, 2026
@arikimari arikimari merged commit e61859a into master Jan 15, 2026
18 checks passed
@arikimari arikimari deleted the add-ddr-config branch January 15, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants