-
Notifications
You must be signed in to change notification settings - Fork 0
Modify default ddr config handling #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
51c996c to
b1e583b
Compare
|
I'd suggest not adding the CONFIG flag here; it is a bit confusing since some configuration is always needed. Instead, in nuttx / imx9_ddr_training.c, make a "struct dram_timing_info * weak_function imx9_ddr_config()", returning a pointer to the default structure and call it directly in the beginning of "imx9_dram_init" to initialize the "ptiming" variable there. Then we (or any board) can simply add an own version of the imx9_ddr_config(), which returns a pointer to our own structure. |
2736994 to
dc7dad1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, but perhaps add also the evk settings to the evk board with the same commit?
i.e.: The following should work
export PATH=$PATH:<path to compiler>
cd <path to nuttx>
./tools/configure.sh imx93-evk:bootloader
make
With this it would fail for the target, because there is no imx9_ddr_config function defined for the plain nuttx board.
When the imx9_ddr_config is also defined for the nuttx board, this commit can be upstreamed as well.
Also, please update the commit message (there is no longer the CONFIG_IMX9_DDR_CONFIG flag). Commit message should just describe that the default configuration is removed and ddr configuration is added to board instead.
|
imx93 EVK does not have CONFIG_IMX9_DDR_TRAINING set so there is no need for imx9_ddr_config |
dc7dad1 to
c94f78e
Compare
|
imx93-evk:bootloader configuration has it, it doesn't link with this commit, just try it. |
c94f78e to
d831f20
Compare
|
Looks good, let's just fix the commit title&message and the style check error (missing blank line). |
d831f20 to
5b9e979
Compare
Remove default ddr config Add imx9_ddr_config() function to return default config Signed-off-by: Ari Kimari <[email protected]>
5b9e979 to
03593b7
Compare
Summary
Remove default ddr configuration. Add function to return ddr configuration
Impact
Testing