Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: when sending snapshot, snapshot.Next iterates forever until raft error #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: when sending snapshot, snapshot.Next iterates forever until raft error #23

wants to merge 1 commit into from

Conversation

Maslino
Copy link

@Maslino Maslino commented Jun 11, 2021

This PR fixes two problems:

  1. If snapshot.Next returns io.EOF, the sending loop should be ended
  2. Writing zero payload to buffer will cause message decode error

@Maslino Maslino mentioned this pull request Jun 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Maslino