Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize definitions.units #156

Merged
merged 16 commits into from
Mar 16, 2024
Merged

Reorganize definitions.units #156

merged 16 commits into from
Mar 16, 2024

Conversation

tiffany352
Copy link
Owner

Changes to definitions.units

  • Added vim folds repurposing the !category/!endcategory syntax. There's a modeline at the bottom of the file for this.
  • To make the vim folds work better, every single unit now has a category. I also moved them around a little bit so that each category collapses to a single line. This makes the file much easier to navigate. Kind of acts as its own table of contents.
  • Rearranged some of the categories, and moved things between categories.
  • Adjusted several comments, and added an explanation of the file to the top.
  • Deleted some legacy GNU Units directives like !utf8 that Rink will never use. Also several of the function/LUTs that are commented out.
  • Uncommented some fractions that apparently GNU Units didn't like. Also uncommented googol.
  • Moved mercury to the periodic table section.
  • Moved the 4 newest elements to be alphabetically sorted.
  • Added atomic numbers to every element. (I double checked that the numbers are correct, but I might have still gotten some mixed up...)
  • Fixed a few typos and trailing whitespace.

image

Changes to rink-core

  • Now prints an error on unrecognized directives instead of silently ignoring them.
  • Ignores categories for non-units. This may be re-added later but it will require refactoring Context::categories to respect namespaces.
  • Improved some of the error messages from the units DB loader.

@tiffany352 tiffany352 merged commit 1f5f636 into master Mar 16, 2024
1 of 2 checks passed
@tiffany352 tiffany352 deleted the units-db-refresh branch March 16, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant