Reimplement classes in S7 #6364
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b038e8f.
Merge branch 'main' into S7_objects # Conflicts: # R/aes.R # R/plot-construction.R # R/plot.R # R/theme.R
Merge branch 'main' into S7_elements # Conflicts: # DESCRIPTION
Merge branch 'main' into S7_objects # Conflicts: # DESCRIPTION
thomasp85
requested changes
May 14, 2025
|
|
||
| #' @export | ||
| print.uneval <- function(x, ...) { | ||
| `print.ggplot2::mapping` <- function(x, ...) { |
There was a problem hiding this comment.
Do you know the timeline for resolving this?
Merge branch 'S7_objects' into S7_elements # Conflicts: # NAMESPACE # R/plot-construction.R # R/theme.R # R/zzz.R # man/ggplot_add.Rd # tests/testthat/test-theme.R
S7 elements
|
#6355 is now merged in via teunbrand#16 |
Closed
teunbrand
commented
May 14, 2025
|
I'm slightly annoyed that we have a |
|
I'm open to suggestions, but can also live a long and happy life with the discrepancy |
|
Alright let's not worry about it too much then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix a large part of #6352.
Briefly it implements the following S7 classes:
I've put in the usual extractors and replacers (
[,[[,$and their<-methods) for the ggplot/ggplot_built classes for backwards compatibility. The code internally now uses@though, so that we can deprecate the usual extractors/replacers later.