Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "optimal" option for weight_func() #372

Merged
merged 2 commits into from
Feb 12, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
remove "optimal" option for weight_func()
hfrick committed Jan 30, 2025
commit d6fbce9c52ab0ae5c78ddd3505fc7c45f05a947a
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -11,8 +11,12 @@

* For space-filling designs for $p$ parameters, there is a higher likelihood of finding a space-filling design for `1 < size <= p`. Also, single-point designs now default to a random grid (#363).

## Breaking changes

* The `grid_*()` functions now error instead of warn when provided with the wrong argument to control the grid size. So `grid_space_filling()`, `grid_random()`, `grid_max_entropy()`, and `grid_latin_hypercube()` now error if used with a `levels` argument and `grid_regular()` now errors if used with a `size` argument (#368).

* The `"optimal"` option for the `weight_func()` parameter has been removed since it is choosing the optimal value based on the resubstition error (#370).


# dials 1.3.0

3 changes: 1 addition & 2 deletions R/param_weight_func.R
Original file line number Diff line number Diff line change
@@ -29,6 +29,5 @@ values_weight_func <- c(
"cos",
"inv",
"gaussian",
"rank",
"optimal"
"rank"
)
2 changes: 1 addition & 1 deletion man/weight_func.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions tests/testthat/_snaps/constructors.md
Original file line number Diff line number Diff line change
@@ -187,9 +187,9 @@
print(fun_ish)
Message
Qualitative Parameter
10 possible values include:
9 possible values include:
'rectangular', 'triangular', 'epanechnikov', 'biweight', 'triweight', 'cos',
'inv', 'gaussian', 'rank', and 'optimal'
'inv', 'gaussian', and 'rank'

---