Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update verge_taglines to correctly select text after site update #2980

Merged
merged 1 commit into from
Mar 23, 2025

Conversation

joevgreathead
Copy link
Contributor

What is this?

This is a bug fix to the Verge taglines app which recently started returning the default text ("THE VERGE") after The Verge updated their page layout and structure again so that the graphql endpoint previously used was no longer functional.

How?

This changes the app back to a previous implementation method which searches the html content since the tagline is now, once again, present in the base HTML returned.

Tasks

  • I have run pixlet check to verify my app passes.

@joevgreathead joevgreathead requested a review from matslina as a code owner March 22, 2025 18:19
@tidbyt
Copy link

tidbyt bot commented Mar 22, 2025

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of random.star requires review
Original Author The original author matches the PR author

@joevgreathead
Copy link
Contributor Author

Previously signed the CLA and build is green. Just awaiting a review.

@joevgreathead joevgreathead force-pushed the fix/verge-taglines-update branch from b494942 to 09c4eb2 Compare March 22, 2025 23:29
@drudge drudge merged commit 958d104 into tidbyt:main Mar 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants