-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New app: Noise #2467
New app: Noise #2467
Conversation
Next StepsHello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:
Automated Review SuccessfulMagical robots have reviewed your change and it looks good to go! 🤖
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Is the 1 second execution limit really necessary? It runs consistently under 1 second on my machine, and 1.4 seconds on this runner. There's a fair amount of math going on here, and I feel the constraints are quite limiting. In order to get this below 1 second on a runner (very difficult to test from a local machine), I will have to either:
Wondering if there is any flexibility here. |
FWIW, it is consistently over a second to render on my laptop. From the point of view of hundreds and thousands of apps rendering with different settings on the servers constantly, it's more an ecosystem-wide scalability problem than it is a single app problem. For ideas to make it overall faster: Can you use any caching at all? Can "common" calculations be looked up instead of redone on the fly? I haven't looked at the code yet but I am happy to give a review if you are interested. |
Thanks @jmanske, there isn't anything cacheable. The generative nature of the app means we WANT it to be different every run, and each pixel of each frame is pseudorandom. I understand the reason for the limit, I just feel a little short-sold on what we're permitted to do here. I honestly wouldn't mind if local apps had access to schemas and could run code, like maybe on your phone, instead of being a glorified GIF. See also: tidbyt/pixlet#1075 |
Have you looked into private apps at all? It's $5 a month to be able to run whatever code on their server and works more or less like apps in the community repo. I do not think you're beholden to the 1 second rendering limit for those. I use private apps a ton for pre-releasing stuff so at least I can enjoy it before I'm ready to push or can work out kinks like you might be dealing with here. Definitely agree that the restrictions are sometimes a bummer. |
We're automatically closing this issue because it hasn't had any activity in 30 days. If that seems like a mistake, please feel free to re-open. Thanks! |
This PR adds a configurable Simplex Noise generator app, which makes pretty, ambient, animated textures.