✨ Live-Reload: Support uvicorn option "no access log" #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafaelWO
changed the title
|
Would be great to have this merged - thanks in advance, @tiangolo, for taking a look! |
RafaelWO
force-pushed
the
feature/live-releoad-support-no-access-log
branch
from
6bf38c3
to
2fc3255
Compare
* ✅ Extend tests
RafaelWO
force-pushed
the
feature/live-releoad-support-no-access-log
branch
from
2fc3255
to
54db61e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #177
This MR adds the feature of disabling the uvicorn access log while using live-reload via
start-reload.sh. Specifically, the option--no-access-logis passed to to uvicorn ifACCESS_LOGis set to an empty value.