Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Update ruff from 0.2.0 to 0.4.1 and fix deprecated scripts… #902

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ryankwondev
Copy link

⬆️ Update ruff from 0.2.0 to 0.4.1 and fix deprecated scripts commands

  • Upgraded the "ruff = "0.2.0"" dependency in pyproject.toml to "ruff = "0.4.1"".
  • Due to the ruff version upgrade, using the ruff [dir] format has been deprecated (warning: ruff is deprecated. Use ruff check instead.).
  • Accordingly, updated the commands in format.sh and lint.sh script.
  • The readability of existing files has been improved by applying new rules and formatting.

🚨 DEAR MAINTAINERS,

As a result of the impact of bullet point no. 4, the format of the ... return type has been uniformly changed. If this change is undesirable, it seems that additional formatting rules need to be added.

before:

        bind_arguments: Optional[Dict[str, Any]] = None,
        _parent_execute_state: Optional[Any] = None,
        _add_event: Optional[Any] = None,
    ) -> TupleResult[_TSelectParam]:
        ...

after:

        bind_arguments: Optional[Dict[str, Any]] = None,
        _parent_execute_state: Optional[Any] = None,
        _add_event: Optional[Any] = None,
    ) -> TupleResult[_TSelectParam]: ...

@ryankwondev
Copy link
Author

(+) I think the cause of the pre-commit process, impact of bullet point no. 4, does not seem to be present in this PR's file diff.

Copy link

📝 Docs preview for commit ceb442e at: https://188583b9.sqlmodel.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant