Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial restructure of image viewer, fixes some immedate bugs #1351

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

CTalvio
Copy link
Collaborator

@CTalvio CTalvio commented May 3, 2024

Pull Request Description

Starting work on the image viewer. Here is an initial take of on a refactor that works around some of the quirks of extendedimage.

I used a stack to make the image viewer widget the size of the screen, which seems to be the only way to avoid the bugs the current viewer is suffering from.

Hence the scaffold and appbar get ditched in favor of simple containers for any buttons we need, stacked atop the image.

I found that layoutInsets can be used to have the initial size of the image limited to the are that is not covered by buttons.

Issue Being Fixed

The inability of the image to fill the screen in some circumstances, causing it to get cut off for seemingly no reason. This was especially prevalent in landscape aspect ratios.

Screenshots / Recordings

Kooha-2024-05-03-22-54-31.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@CTalvio CTalvio added the on-hold Issue that requires more information or reproducible steps label May 4, 2024
@CTalvio
Copy link
Collaborator Author

CTalvio commented May 4, 2024

gonna investigate how this handles system padding (notches, softkeys etc.)

@CTalvio CTalvio removed the on-hold Issue that requires more information or reproducible steps label May 4, 2024
@CTalvio
Copy link
Collaborator Author

CTalvio commented May 4, 2024

Ok, the image viewer is now in a really good place I think. Not massively different but now it doesn't seem to suffer from any "quirks".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant