Initial restructure of image viewer, fixes some immedate bugs #1351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Starting work on the image viewer. Here is an initial take of on a refactor that works around some of the quirks of extendedimage.
I used a stack to make the image viewer widget the size of the screen, which seems to be the only way to avoid the bugs the current viewer is suffering from.
Hence the scaffold and appbar get ditched in favor of simple containers for any buttons we need, stacked atop the image.
I found that
layoutInsets
can be used to have the initial size of the image limited to the are that is not covered by buttons.Issue Being Fixed
The inability of the image to fill the screen in some circumstances, causing it to get cut off for seemingly no reason. This was especially prevalent in landscape aspect ratios.
Screenshots / Recordings
Kooha-2024-05-03-22-54-31.mp4
Checklist
semanticLabel
s where applicable for accessibility?