Skip to content

Feat/persist data #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Feat/persist data #78

wants to merge 8 commits into from

Conversation

Vilayat-Ali
Copy link
Contributor

Added feature to make visitor name and theme data persist between user sessions.

@vercel
Copy link

vercel bot commented Oct 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
terminal-portfolio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 8:12pm

@Vilayat-Ali Vilayat-Ali mentioned this pull request Oct 5, 2023
Open
@Vilayat-Ali
Copy link
Contributor Author

BTW this feature is implemented on /profile route as you said that Home.tsx is under work.

@thtauhid thtauhid linked an issue Oct 6, 2023 that may be closed by this pull request
Persist data like theme, etc to persist between sessions #77
Open
@Vilayat-Ali
Copy link
Contributor Author

@thtauhid it is already tested by me on deployed link as well as on local

@Vilayat-Ali
Copy link
Contributor Author

@thtauhid also test and verify this PR and if it works as required, can we merge it too?

@thtauhid
Copy link
Owner

thtauhid commented Oct 6, 2023

@Vilayat-Ali the data persistence feature is working as expected.
I just wanted to ask why username is in the localstorage?
image

@thtauhid
Copy link
Owner

thtauhid commented Oct 6, 2023

Also, can you merge the main branch into this branch once?

@Vilayat-Ali
Copy link
Contributor Author

@thtauhid I think that's a result of mistake in setter values. Lemme clean that and push it again

@thtauhid
Copy link
Owner

thtauhid commented Oct 6, 2023 •
edited
Loading

I've added the label. It may take up to 6 hours to update.
image

@Vilayat-Ali
Copy link
Contributor Author

I've added the label. It may take up to 6 hours to update. image

Oh thanks

@Vilayat-Ali
Copy link
Contributor Author

Hey cleaning done! Also, do we need to store history too?

@thtauhid
Copy link
Owner

Hi @Vilayat-Ali no need to store history for now.

@thtauhid
Copy link
Owner

@Vilayat-Ali do push the updated changes so I can check them.

@Vilayat-Ali
Copy link
Contributor Author

sure. Will shoot an update by EOD today

@thtauhid
Copy link
Owner

Hi @Vilayat-Ali any update?

@thtauhid thtauhid added the stale label Dec 25, 2023
@Vilayat-Ali
Copy link
Contributor Author

@thtauhid sorry I was busy with holidays. Will It is all completed. Lemme raise PRs whenever I get time today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
change requested stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Persist data like theme, etc to persist between sessions
2 participants
@Vilayat-Ali @thtauhid