Replace murmur hash with faster hash method #357
Conversation
|
This looks awesome! Our team has also been working on a package called https://github.com/segmentio/ui-box that implements a React Box primitive that tries to avoid calling a hash function at all when possible. However, this is not a replacement of glamor or anything — just might be a interesting resource to implement more speed improvements. I am curious what the delta is in speed between your hash function and mrmrs hash? |
|
@jeroenransijn I can say only for our project, which we found 4 times faster (rendering of react). Possibly because we might have abused using of glamor, so in others it might be less. |
|
Hey @blackswanny , since we at Signavio believe in this library we want to continue developing it further. Therefore, we've forked it and will release it as |
|
@frontendphil I didn't find your repo in github. Also the research shown that it's not completely better, at least not in all browsers. |
|
@blackswanny this is the repo: https://github.com/signavio/glamor Do you have some more statistics? |
|
@frontendphil See investigation here |
As discussed in issues of this project and with similar emotion project collaborators, the murmur hash function is very slow and for the needs of this project can be replaced with faster hash.
The provided function is tested on real enterprise project also and provides up to 4 billion unique hashes