Enhance patch UI with buttons for better interaction

[lilyremigia]

Added buttons for moving patches between lists, reordering selected patches, and improving patch selection clarity in the UI. Updated methods to handle button actions and ensure smoother interaction logic.

Fixes #274 .

[lilyremigia]

Perhaps, we could also remove the other buttons for a cleaner UI?

[lilyremigia]

Also, I just realised, I forgot to hide buttons when not hovering over them.

[brliron]

After a bit of testing:

• I don't like how it looks. I think that big gray box clashes too much with the white background. Maybe things like some transparency, round corners, a light blue border to ease the transition, or just a lighter background on the buttons would help? Or maybe it's just me?
• I don't like the buttons being aligned on the left, because they're over the name of the patch. I think that one is less subjective, that it would be a problem for many people. I think aligning them to the right would be better.
• I feel some discomfort while using these buttons, but I think that's mostly because of the previous point, outside of that I think these buttons could feel nice to use.
• I did have a hard time following the item while trying to use the up/down arrows. Maybe we need to make something to help with that, like selecting the item after it moved? Or maybe this was a problem only because of the previous issue with the buttons being over the text? I'll have to try it out after we fix that, maybe we don't need to change anything (btw, I was testing with 2 items in the list, which is probably the worst case because every item in the list moves).

Otherwise, the code looks fine. And yeah, I don't think we need to keep the old arrows if we add these ones.

[lilyremigia]

This is probably as good as it gets, unless we want to add some kind of animation or "moved here" style. Alternativly, I guess we could do drag & drop for reordering.

[brliron]

That wasn't what I was thinking about, but it does feel quite good to use, I like it. I'm frustrated that the patch ids have an ellipsis at the end and that I can't read them entirely. Maybe that one can be solved with a tooltip? But outside of this problem, I like it.

Some other remarks:

• The up / down arrows should be grayed out when they don't do anything (the up arrow on the 1st element and the down arrow on the last element).
• On the left column (the one with the repo and patch id) of the selected patches, it's hard to see the difference between the lines. Like, in the screenshot below, it's hard to understand that "thpatch" and "lang_fr" are together, describing the same patch, and that "Arandui" and "th07_ut_..." are together describing another patch. Maybe you could split them with a thin horizontal gray line?
• There is a new bug: the search doesn't hide empty repos.
• There's also a change in behavior: the repos are now collapsed at the beginning. I'm not sure if this is intentional, I think I prefer when they're all expanded by default, but both options have their pros and cons.
• In the available patches, if you single-click on an item, it becomes blue and the arrow's background stays white (not a problem), but there's a one pixel column of blue on the left of the arrow's background.
• In the selected patches, you can remove an item by double-clicking on it, but it doesn't become blue when you single click on it.
  

[32th-System]

2025-03-13.22-41-02.mp4

Tested out touch behavior. If your finger happens to touch the spot where the arrow is when you hover with the mouse, that arrow's action is performed automatically. If you just select an item with the touch screen though, the arrows show up where they should.

[lilyremigia]

If I'm correct all of those points should have been addressed in some capacity in the above changes.

[brliron]

Looks good.
@32th-System Can you test if your issue with touchscreens have been resolved?

[32th-System]

I'll do a more proper test when I'm home, but I can test on Linux with touchscreen right now.

EDIT: Wine itself doesn't seem to support touchscreen at all. I'll do my testing on Windows when I get home, but testing touchscreen stuff in Wine, for now, seems completely pointless

[32th-System]

For future reference: cccab28

Some platforms we support don't show emojis correctly

[brliron]

Quick comment about your latest commit, I don't see Page2_advanced.PropertyChanged being used anywhere, and because of that, I don't think the inheritance on INotifyPropertyChanged is useful. Does PropertyChanged do something just by existing, or is that something from a previous test that your forgot to remove?

[lilyremigia]

Pretty sure Bindings don't work without it, even if they're get only.

[lilyremigia]

I tested it in Windows 7 and works, but for whatever reason the Wingdings arrows are misaligned. If anyone has any idea, they're free to contribute, but otherwise, if this also works on XP I would merge this and worry about touch support in a different, perhaps more comprehensive issue.

[brliron]

Pretty sure Bindings don't work without it, even if they're get only.

Well, I'm using a lot of bindings in https://github.com/thpatch/thcrap/blob/patch_editor/thcrap_configure_v3/Page2_PatchEditor.xaml , and no class in https://github.com/thpatch/thcrap/blob/patch_editor/thcrap_configure_v3/Page2_PatchEditor.xaml.cs inherits from INotifyPropertyChanged or declares a PropertyChanged member.

And I just tested on your latest changes quickly on Windows 10, it seems to work properly without them.

[brliron]

if this also works on XP

thcrap_configure_v3 uses .NET Framework 4.8 which isn't compatible with Windows XP, so there's nothing to test there.

[lilyremigia]

Pretty sure Bindings don't work without it, even if they're get only.

Well, I'm using a lot of bindings in https://github.com/thpatch/thcrap/blob/patch_editor/thcrap_configure_v3/Page2_PatchEditor.xaml , and no class in https://github.com/thpatch/thcrap/blob/patch_editor/thcrap_configure_v3/Page2_PatchEditor.xaml.cs inherits from INotifyPropertyChanged or declares a PropertyChanged member.

And I just tested on your latest changes quickly on Windows 10, it seems to work properly without them.

Test it in Win7 without, it's the font binding that will won't work, if I remember correctly.

[lilyremigia]

if this also works on XP

thcrap_configure_v3 uses .NET Framework 4.8 which isn't compatible with Windows XP, so there's nothing to test there.

If Vista is supported, then perhaps we could check if it also supports Segoe UI Symbol. That font might be less cursed making the arrows line-up naturally.

Never mind, after a little bit of searching, 4.8 doesn't support Vista either.

[brliron]

Pretty sure Bindings don't work without it, even if they're get only.

Well, I'm using a lot of bindings in https://github.com/thpatch/thcrap/blob/patch_editor/thcrap_configure_v3/Page2_PatchEditor.xaml , and no class in https://github.com/thpatch/thcrap/blob/patch_editor/thcrap_configure_v3/Page2_PatchEditor.xaml.cs inherits from INotifyPropertyChanged or declares a PropertyChanged member.
And I just tested on your latest changes quickly on Windows 10, it seems to work properly without them.

Test it in Win7 without, it's the font binding that will won't work, if I remember correctly.

I just tried on a Windows 7 VM (installing .NET Framework 4.8 was surprisingly hard because it depends on a few Windows updates and Windows Update seems dead), and it seems to work fine for me.