Skip to content

Conversation

@montycheese
Copy link

@montycheese montycheese commented Dec 15, 2025

  • Add @base-org/account 2.5.0 dependency
  • Implement Base Account SDK wallet connector
  • Add base-account-web.ts with EIP-1193 provider implementation
  • Add base-account-wallet.ts with core wallet logic
  • Export types and helper functions
  • Maintain backwards compatibility with coinbase/wallet-sdk

PR-Codex overview

This PR introduces support for the Base Account SDK in the thirdweb package, allowing users to create and connect wallets using the new SDK. It adds new constants, types, and wallet creation options, along with necessary functions for handling wallet connections and interactions.

Detailed summary

  • Added dependency for @base-org/account.
  • Introduced BASE_ACCOUNT constant in constants.ts.
  • Exported new types and functions related to Base Account SDK in wallets.ts.
  • Implemented wallet creation and connection logic in create-wallet.ts.
  • Created helper functions for Base Account SDK in base-account-wallet.ts.
  • Defined BaseAccountProvider interface and connection methods in base-account-web.ts.
  • Added functionality for handling account and chain changes.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

  - Add @base-org/account 2.5.0 dependency
  - Implement Base Account SDK wallet connector
  - Add base-account-web.ts with EIP-1193 provider implementation
  - Add base-account-wallet.ts with core wallet logic
  - Export types and helper functions
  - Maintain backwards compatibility with coinbase/wallet-sdk
@changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2025

⚠️ No Changeset found

Latest commit: 46e2bff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 15, 2025

@montycheese is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 15, 2025
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​base-org/​account@​2.5.09910010098100

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant