Skip to content

[Dashboard] Show EOA server wallets by default #7645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jul 18, 2025


PR-Codex overview

This PR focuses on updating the transaction handling and wallet display components in the dashboard application. It enhances the transaction status handling and replaces the SmartAccountCell component with WalletAddress for better clarity in wallet representation.

Detailed summary

  • Added packages/api to pnpm-lock.yaml.
  • Updated transaction status handling in tx-table-ui.tsx.
  • Replaced SmartAccountCell with WalletAddress in send-test-tx.client.tsx.
  • Modified state management in wallet-table-ui.client.tsx for contract wallets.
  • Changed table header to reflect the type of address shown based on state.
  • Updated wallet address rendering logic in ServerWalletsTableUI.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features

    • Added a toggle to switch between viewing ERC4337 Smart Account addresses and EOA addresses in the wallet table.
  • Improvements

    • Updated wallet selection in the send test transaction modal to display wallet addresses more clearly.
    • The transaction status badge now always displays, defaulting to "QUEUED" when status is unavailable.
  • Style

    • Enhanced layout responsiveness and alignment in the wallet table header and controls.

Copy link

changeset-bot bot commented Jul 18, 2025

⚠️ No Changeset found

Latest commit: 9c6857e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2025 8:47am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jul 18, 2025 8:47am
nebula ⬜️ Skipped (Inspect) Jul 18, 2025 8:47am
thirdweb_playground ⬜️ Skipped (Inspect) Jul 18, 2025 8:47am
wallet-ui ⬜️ Skipped (Inspect) Jul 18, 2025 8:47am

Copy link
Contributor

coderabbitai bot commented Jul 18, 2025

Walkthrough

The updates focus on wallet address display logic and transaction status handling in the dashboard's transaction analytics and server wallet tables. Components were refactored to use consistent address display elements, toggle logic was updated for smart account visibility, and transaction status now defaults to "QUEUED" when undefined.

Changes

File(s) Change Summary
.../transactions/analytics/send-test-tx.client.tsx Replaced SmartAccountCell with WalletAddress for wallet display in modal; updated imports and props accordingly.
.../transactions/analytics/tx-table/tx-table-ui.tsx Changed transaction status default to "QUEUED" instead of null; always renders a status badge.
.../transactions/server-wallets/wallet-table/wallet-table-ui.client.tsx Replaced "Show Signer Addresses" toggle with "Show ERC4337 Smart Account Addresses"; updated table display logic, labels, and layout; refactored address cell rendering and SmartAccountCell scope.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ServerWalletsTableUI
    participant SmartAccountCell
    participant WalletAddress

    User->>ServerWalletsTableUI: Toggles "Show ERC4337 Smart Account Addresses"
    alt showContractWallets = true
        ServerWalletsTableUI->>SmartAccountCell: Render smart account address
    else showContractWallets = false
        ServerWalletsTableUI->>WalletAddress: Render EOA address
    end
Loading
sequenceDiagram
    participant TxTableUI
    participant TxStatusCell

    TxTableUI->>TxStatusCell: Render transaction status
    alt transaction.executionResult.status is defined
        TxStatusCell->>TxTableUI: Display status badge with status
    else status undefined
        TxStatusCell->>TxTableUI: Display status badge with "QUEUED"
    end
Loading

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 22efb00 and 9c6857e.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/transactions/analytics/send-test-tx.client.tsx (3 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/transactions/analytics/tx-table/tx-table-ui.tsx (1 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/transactions/server-wallets/wallet-table/wallet-table-ui.client.tsx (4 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/transactions/analytics/send-test-tx.client.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/transactions/analytics/tx-table/tx-table-ui.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/transactions/server-wallets/wallet-table/wallet-table-ui.client.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Size
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Unit Tests
  • GitHub Check: Build Packages
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jul 18, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review July 18, 2025 08:22
@joaquim-verges joaquim-verges requested review from a team as code owners July 18, 2025 08:22
@joaquim-verges joaquim-verges changed the title [Dashboard] Replace SmartAccountCell with WalletAddress component [Dashboard] Show EOA server wallets by default Jul 18, 2025
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.43%. Comparing base (6e62a3a) to head (9c6857e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7645   +/-   ##
=======================================
  Coverage   56.43%   56.43%           
=======================================
  Files         908      908           
  Lines       58193    58193           
  Branches     4226     4226           
=======================================
  Hits        32840    32840           
  Misses      25244    25244           
  Partials      109      109           
Flag Coverage Δ
packages 56.43% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jul 18, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.25 KB (0%) 1.3 s (0%) 366 ms (+60.54% 🔺) 1.7 s
thirdweb (cjs) 353.31 KB (0%) 7.1 s (0%) 1.7 s (-0.1% 🔽) 8.8 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 84 ms (+483.97% 🔺) 198 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 39 ms (+923.53% 🔺) 49 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 63 ms (+89.06% 🔺) 455 ms

@joaquim-verges joaquim-verges force-pushed the _Dashboard_Replace_SmartAccountCell_with_WalletAddress_component branch from 22efb00 to 9c6857e Compare July 18, 2025 08:38
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 18, 2025 08:38 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 18, 2025 08:38 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 18, 2025 08:38 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 18, 2025 08:38 Inactive
@joaquim-verges joaquim-verges merged commit 84eaded into main Jul 20, 2025
25 checks passed
@joaquim-verges joaquim-verges deleted the _Dashboard_Replace_SmartAccountCell_with_WalletAddress_component branch July 20, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant