-
Notifications
You must be signed in to change notification settings - Fork 562
[Dashboard] Show EOA server wallets by default #7645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Show EOA server wallets by default #7645
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe updates focus on wallet address display logic and transaction status handling in the dashboard's transaction analytics and server wallet tables. Components were refactored to use consistent address display elements, toggle logic was updated for smart account visibility, and transaction status now defaults to "QUEUED" when undefined. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ServerWalletsTableUI
participant SmartAccountCell
participant WalletAddress
User->>ServerWalletsTableUI: Toggles "Show ERC4337 Smart Account Addresses"
alt showContractWallets = true
ServerWalletsTableUI->>SmartAccountCell: Render smart account address
else showContractWallets = false
ServerWalletsTableUI->>WalletAddress: Render EOA address
end
sequenceDiagram
participant TxTableUI
participant TxStatusCell
TxTableUI->>TxStatusCell: Render transaction status
alt transaction.executionResult.status is defined
TxStatusCell->>TxTableUI: Display status badge with status
else status undefined
TxStatusCell->>TxTableUI: Display status badge with "QUEUED"
end
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7645 +/- ##
=======================================
Coverage 56.43% 56.43%
=======================================
Files 908 908
Lines 58193 58193
Branches 4226 4226
=======================================
Hits 32840 32840
Misses 25244 25244
Partials 109 109
🚀 New features to boost your workflow:
|
size-limit report 📦
|
22efb00
to
9c6857e
Compare
PR-Codex overview
This PR focuses on updating the transaction handling and wallet display components in the dashboard application. It enhances the transaction status handling and replaces the
SmartAccountCell
component withWalletAddress
for better clarity in wallet representation.Detailed summary
packages/api
topnpm-lock.yaml
.tx-table-ui.tsx
.SmartAccountCell
withWalletAddress
insend-test-tx.client.tsx
.wallet-table-ui.client.tsx
for contract wallets.ServerWalletsTableUI
.Summary by CodeRabbit
New Features
Improvements
Style