-
Notifications
You must be signed in to change notification settings - Fork 550
Version Packages #7414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #7414
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Caution Review failedThe pull request is closed. ## Walkthrough
This update increments patch versions for the `thirdweb`, `nebula`, and `wagmi-adapter` packages, and updates their changelogs accordingly. It also removes changeset files related to fixes for handling non-URL metadata images in payment widgets and wallet row alignment in the wide connect modal, reflecting the completion and release of those fixes.
## Changes
| Files/Groups | Change Summary |
|-----------------------------------------------------|------------------------------------------------------------------------------------------------|
| .changeset/fluffy-cows-swim.md, .changeset/slow-sites-call.md | Removed changeset files documenting fixes for payment widget metadata image handling and wallet row alignment |
| packages/thirdweb/CHANGELOG.md, package.json | Added patch release 5.104.1 with fixes for non-URL metadata images, wallet row alignment, EOA execution options, and dependency update; bumped version |
| packages/nebula/CHANGELOG.md, package.json | Added patch release 0.1.1; upgraded dependency to thirdweb 5.104.1; bumped version |
| packages/wagmi-adapter/CHANGELOG.md, package.json | Added patch release 0.2.96; bumped version |
| packages/engine/CHANGELOG.md, package.json | Added patch release 3.0.4 with support for EOA execution options for server wallets; bumped version |
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant User
participant PaymentWidget
participant MetadataHandler
User->>PaymentWidget: Submit payment with metadata
PaymentWidget->>MetadataHandler: Process image metadata
MetadataHandler-->>PaymentWidget: Handle both URL and non-URL image values
PaymentWidget-->>User: Display payment result with correct image handling Possibly related PRs
Suggested labels
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/wagmi-adapter/CHANGELOG.md (1)
3-3
: Document release details for 0.2.96
You've added the## 0.2.96
header. Consider including a concise summary or patch notes under this entry to describe the changes shipped in this release for better traceability.packages/thirdweb/CHANGELOG.md (1)
3-8
: Refine changelog entry text for consistency.
The new patch entry looks good, but consider hyphenating “non-URL” and adding a trailing period to match the style of other list items. For example:- Handle non urls for metadata images in payment widgets + Handle non-URL values for metadata images in payment widgets.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.changeset/fluffy-cows-swim.md
(0 hunks)packages/nebula/CHANGELOG.md
(1 hunks)packages/nebula/package.json
(1 hunks)packages/thirdweb/CHANGELOG.md
(1 hunks)packages/thirdweb/package.json
(1 hunks)packages/wagmi-adapter/CHANGELOG.md
(1 hunks)packages/wagmi-adapter/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/fluffy-cows-swim.md
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Unit Tests
- GitHub Check: Build Packages
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (4)
packages/wagmi-adapter/package.json (1)
58-58
: Confirm version bump to 0.2.96
Theversion
field has been updated to0.2.96
as expected for this patch release. Please verify it matches the entry inCHANGELOG.md
and will correctly trigger the npm publish workflow.packages/nebula/package.json (1)
3-3
: Approve version bump
The package version has been correctly updated from0.1.0
to0.1.1
to reflect the new patch release.packages/nebula/CHANGELOG.md (1)
3-9
: Changelog entry formatting is consistent.
The0.1.1
header and ensuing patch changes follow the existing template, and the dependency bump is correctly indented.packages/thirdweb/package.json (1)
407-407
: ```shell
#!/bin/bashExtract the package name from packages/thirdweb/package.json
pkg=$(jq -r '.name' packages/thirdweb/package.json)
echo "Checking NPM for [email protected]"Verify if version 5.104.1 is published on npm
npm view "[email protected]" version
</details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7414 +/- ##
=======================================
Coverage 52.08% 52.08%
=======================================
Files 947 947
Lines 63636 63636
Branches 4216 4216
=======================================
Hits 33146 33146
Misses 30384 30384
Partials 106 106
🚀 New features to boost your workflow:
|
size-limit report 📦
|
eb12284
to
4e2e9f2
Compare
4e2e9f2
to
ce04476
Compare
ce04476
to
0db0806
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/[email protected]
Patch Changes
ef2895f
Thanks @d4mr! - Support EOA Execution Options for Server Wallets@thirdweb-dev/[email protected]
Patch Changes
3107ba1
,ef2895f
,c26be2d
]:[email protected]
Patch Changes
#7413
3107ba1
Thanks @joaquim-verges! - Handle non urls for metadata images in payment widgets#7429
ef2895f
Thanks @d4mr! - Support EOA Execution Options for Server Wallets#7425
c26be2d
Thanks @joaquim-verges! - Fix wallet row alignement in wide connect modalUpdated dependencies [
ef2895f
]:@thirdweb-dev/[email protected]
PR-Codex overview
This PR focuses on updating package versions and changelogs for several components of the
thirdweb
library, includingthirdweb
,engine
, andnebula
, along with the addition of new entries in their respective changelogs.Detailed summary
version
inpackages/thirdweb/package.json
from5.104.0
to5.104.1
version
inpackages/wagmi-adapter/package.json
from0.2.95
to0.2.96
version
inpackages/engine/package.json
from3.0.3
to3.0.4
version
inpackages/nebula/package.json
from0.1.0
to0.1.1
packages/engine/CHANGELOG.md
for version3.0.4
packages/nebula/CHANGELOG.md
for version0.1.1
packages/thirdweb/CHANGELOG.md
for version5.104.1
Summary by CodeRabbit
New Features
Bug Fixes
Chores