Skip to content

[TOOL-4689] Dashboard: Integrate ERC20Asset contract in token creation flow #7344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: yash/ocr-contracts-integration
Choose a base branch
from

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Jun 16, 2025


PR-Codex overview

This PR focuses on enhancing the token creation process in the dashboard by introducing a new ERC20Asset type, refining the UI components, and improving the handling of token distribution and sale modes.

Detailed summary

  • Added ERC20Asset to the contract type options.
  • Modified UI components for better spacing and layout.
  • Introduced Skeleton loading states for better user experience.
  • Updated token distribution schema to include directSale and publicMarket.
  • Implemented new sale modes and configurations for tokens.
  • Removed minting and claim conditions functionalities from the token creation process.
  • Enhanced handling of airdrop and approval transactions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Jun 16, 2025

Copy link

changeset-bot bot commented Jun 16, 2025

⚠️ No Changeset found

Latest commit: 6f13a0d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2025 7:02pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jun 23, 2025 7:02pm
login ⬜️ Skipped (Inspect) Jun 23, 2025 7:02pm
nebula ⬜️ Skipped (Inspect) Jun 23, 2025 7:02pm
thirdweb_playground ⬜️ Skipped (Inspect) Jun 23, 2025 7:02pm
wallet-ui ⬜️ Skipped (Inspect) Jun 23, 2025 7:02pm

Copy link
Contributor

coderabbitai bot commented Jun 16, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jun 16, 2025
@MananTank MananTank marked this pull request as ready for review June 16, 2025 14:58
@MananTank MananTank requested review from a team as code owners June 16, 2025 14:58
Copy link
Member Author

MananTank commented Jun 16, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank mentioned this pull request Jun 16, 2025
Copy link
Contributor

github-actions bot commented Jun 16, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.56 KB (0%) 1.3 s (0%) 237 ms (+113.83% 🔺) 1.5 s
thirdweb (cjs) 350.74 KB (0%) 7.1 s (0%) 874 ms (-6.12% 🔽) 7.9 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 77 ms (+694.58% 🔺) 191 ms
thirdweb/chains (tree-shaking) 530 B (0%) 11 ms (0%) 60 ms (+1410.92% 🔺) 70 ms
thirdweb/react (minimal + tree-shaking) 19.61 KB (0%) 393 ms (0%) 93 ms (+347.72% 🔺) 485 ms

@MananTank MananTank force-pushed the 06-16-_tool-4689_dashboard_integrate_erc20asset_contract_in_token_creation_flow branch from 88e82aa to 90d9498 Compare June 16, 2025 15:19
@MananTank MananTank force-pushed the yash/ocr-contracts-integration branch from bd11486 to 5231fdd Compare June 16, 2025 15:19
@vercel vercel bot temporarily deployed to Preview – login June 16, 2025 15:19 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 16, 2025 15:20 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 16, 2025 15:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 16, 2025 15:20 Inactive
@MananTank MananTank force-pushed the 06-16-_tool-4689_dashboard_integrate_erc20asset_contract_in_token_creation_flow branch from 90d9498 to 936055a Compare June 16, 2025 15:24
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 16, 2025 15:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 16, 2025 15:24 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 16, 2025 15:24 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 16, 2025 15:24 Inactive
@MananTank MananTank force-pushed the 06-16-_tool-4689_dashboard_integrate_erc20asset_contract_in_token_creation_flow branch from 936055a to b4541e3 Compare June 16, 2025 15:42
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 16, 2025 15:42 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 16, 2025 15:42 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 16, 2025 15:42 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 17, 2025 15:32 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 17, 2025 15:32 Inactive
@MananTank MananTank marked this pull request as draft June 19, 2025 17:58
@MananTank MananTank force-pushed the 06-16-_tool-4689_dashboard_integrate_erc20asset_contract_in_token_creation_flow branch from 45c7614 to d363c19 Compare June 23, 2025 17:16
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 23, 2025 17:16 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 23, 2025 17:16 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula June 23, 2025 17:16 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 23, 2025 17:16 Inactive
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (yash/ocr-contracts-integration@47c87ea). Learn more about missing BASE report.

Additional details and impacted files
@@                        Coverage Diff                        @@
##             yash/ocr-contracts-integration    #7344   +/-   ##
=================================================================
  Coverage                                  ?   52.10%           
=================================================================
  Files                                     ?      956           
  Lines                                     ?    64310           
  Branches                                  ?     4243           
=================================================================
  Hits                                      ?    33508           
  Misses                                    ?    30696           
  Partials                                  ?      106           
Flag Coverage Δ
packages 52.10% <ø> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MananTank MananTank force-pushed the 06-16-_tool-4689_dashboard_integrate_erc20asset_contract_in_token_creation_flow branch from d363c19 to 94abdaf Compare June 23, 2025 18:11
@vercel vercel bot temporarily deployed to Preview – nebula June 23, 2025 18:11 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 23, 2025 18:11 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 23, 2025 18:11 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 23, 2025 18:11 Inactive
@MananTank MananTank force-pushed the 06-16-_tool-4689_dashboard_integrate_erc20asset_contract_in_token_creation_flow branch from 94abdaf to 6f13a0d Compare June 23, 2025 18:24
@vercel vercel bot temporarily deployed to Preview – nebula June 23, 2025 18:24 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 23, 2025 18:24 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 23, 2025 18:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 23, 2025 18:24 Inactive
@MananTank MananTank force-pushed the 06-16-_tool-4689_dashboard_integrate_erc20asset_contract_in_token_creation_flow branch from 6f13a0d to 48137da Compare June 23, 2025 18:54
@vercel vercel bot temporarily deployed to Preview – nebula June 23, 2025 18:54 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 23, 2025 18:54 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 23, 2025 18:54 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 23, 2025 18:54 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant