Skip to content

docs: Add page on domain verification #7247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Jun 2, 2025

[Portal] Feature: Add domain verification guide to knowledge base

Notes for the reviewer

This PR adds a new knowledge base article explaining how to verify team email domains, with step-by-step instructions and provider-specific guidance for Cloudflare, AWS Route 53, and Google Cloud DNS. It also updates the sidebar to include this new article and standardizes the capitalization of existing article titles.

How to test

Navigate to the knowledge base section and verify that the new "Verify your team email domain" article appears in the sidebar and renders correctly.

Summary by CodeRabbit

  • Documentation
    • Added a new help page: "Verify your team email domain," featuring benefits, verification steps, and provider-specific DNS setup guidance.
    • Updated the sidebar to include the new page and refined the casing of existing link titles for consistency.

PR-Codex overview

This PR updates the sidebar.tsx file by modifying existing links and adding a new entry for verifying team email domains. It also introduces a new page.mdx file that provides detailed instructions on how to verify a domain, including steps and provider-specific guidance.

Detailed summary

  • Updated link name from "Creating Soulbound NFTs" to "Verify your team email domain" in sidebar.tsx.
  • Added a new link for verifying team email domain with an href.
  • Changed "Console Error Sharing" to "Console error sharing" in sidebar.tsx.
  • Created page.mdx with sections on:
    • Importance of domain verification.
    • Step-by-step instructions for verifying a domain.
    • Provider-specific instructions for Cloudflare, AWS Route 53, and Google Cloud DNS.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jun 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2025 8:40am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) Jun 2, 2025 8:40am
thirdweb_playground ⬜️ Skipped (Inspect) Jun 2, 2025 8:40am
thirdweb-www ⬜️ Skipped (Inspect) Jun 2, 2025 8:40am
wallet-ui ⬜️ Skipped (Inspect) Jun 2, 2025 8:40am

@vercel vercel bot temporarily deployed to Preview – login June 2, 2025 08:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 2, 2025 08:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www June 2, 2025 08:24 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 2, 2025 08:24 Inactive
Copy link

changeset-bot bot commented Jun 2, 2025

⚠️ No Changeset found

Latest commit: 6d52c72

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jun 2, 2025

Walkthrough

A new documentation page, "Verify your team email domain," was introduced, outlining the steps and benefits of domain verification. The sidebar configuration was updated to include this new page at the top of the "How to" section, and the casing of existing sidebar link titles was adjusted for consistency.

Changes

File(s) Change Summary
.../knowledge-base/how-to/verify-your-team-email-domain/page.mdx Added a new documentation page detailing the process and benefits of verifying a team email domain.
.../knowledge-base/sidebar.tsx Inserted a new sidebar link for the above page and updated the casing of existing link titles.

Sequence Diagram(s)

sequenceDiagram
    User->>Portal UI: Navigate to Knowledge Base
    Portal UI->>Sidebar: Render sidebar links
    Sidebar-->>User: Display "Verify your team email domain" link
    User->>Portal UI: Click "Verify your team email domain"
    Portal UI-->>User: Show verification documentation page
Loading
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Jun 2, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@arcoraven arcoraven marked this pull request as ready for review June 2, 2025 08:25
@arcoraven arcoraven requested review from a team as code owners June 2, 2025 08:25
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.55%. Comparing base (f1479b8) to head (6d52c72).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7247   +/-   ##
=======================================
  Coverage   55.55%   55.55%           
=======================================
  Files         908      908           
  Lines       58571    58571           
  Branches     4131     4131           
=======================================
  Hits        32540    32540           
  Misses      25927    25927           
  Partials      104      104           
Flag Coverage Δ
packages 55.55% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arcoraven arcoraven force-pushed the 06-02-docs_add_page_on_domain_verification branch from 3adb39e to 4cb2d98 Compare June 2, 2025 08:26
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 2, 2025 08:26 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 2, 2025 08:26 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www June 2, 2025 08:26 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 2, 2025 08:26 Inactive
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
apps/portal/src/app/knowledge-base/how-to/verify-your-team-email-domain/page.mdx (2)

40-44: Consider improving sentence variety for better readability.

The static analysis tool correctly identified repetitive sentence beginnings. Consider varying the sentence structure for better flow.

 ### Cloudflare
 
-- Navigate to the Cloudflare dashboard.
-- Select your zone and domain.
-- Select *DNS* > *Records*.
-- Select *Add record*.
+- Navigate to the Cloudflare dashboard.
+- Choose your zone and domain.
+- Go to *DNS* > *Records*.
+- Click *Add record*.
🧰 Tools
🪛 LanguageTool

[style] ~43-~43: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...d domain. - Select DNS > Records. - Select Add record. [Cloudflare documentation...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


54-58: Consider improving sentence variety for better readability.

Similar to the Cloudflare section, varying the sentence beginnings would improve readability.

 ### Google Cloud DNS
-- Navigate to the Google Cloud Console.
-- Select *Network Services* > *Cloud DNS*.
-- Select your zone.
-- Select *Add record set*.
+- Navigate to the Google Cloud Console.
+- Go to *Network Services* > *Cloud DNS*.
+- Choose your zone.
+- Click *Add record set*.
🧰 Tools
🪛 LanguageTool

[style] ~57-~57: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...s* > Cloud DNS. - Select your zone. - Select Add record set. [Google Cloud documen...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f1479b8 and 3adb39e.

📒 Files selected for processing (2)
  • apps/portal/src/app/knowledge-base/how-to/verify-your-team-email-domain/page.mdx (1 hunks)
  • apps/portal/src/app/knowledge-base/sidebar.tsx (1 hunks)
🧰 Additional context used
🪛 LanguageTool
apps/portal/src/app/knowledge-base/how-to/verify-your-team-email-domain/page.mdx

[style] ~43-~43: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...d domain. - Select DNS > Records. - Select Add record. [Cloudflare documentation...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~57-~57: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...s* > Cloud DNS. - Select your zone. - Select Add record set. [Google Cloud documen...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Size
  • GitHub Check: Lint Packages
  • GitHub Check: Unit Tests
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
apps/portal/src/app/knowledge-base/how-to/verify-your-team-email-domain/page.mdx (1)

1-59: Excellent comprehensive documentation!

This documentation page is well-structured and provides thorough coverage of domain verification. The content is user-friendly, includes practical examples, and covers all major DNS providers.

🧰 Tools
🪛 LanguageTool

[style] ~43-~43: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...d domain. - Select DNS > Records. - Select Add record. [Cloudflare documentation...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~57-~57: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...s* > Cloud DNS. - Select your zone. - Select Add record set. [Google Cloud documen...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

apps/portal/src/app/knowledge-base/sidebar.tsx (2)

25-28: Perfect integration of the new documentation page.

The new sidebar entry is correctly positioned at the top of the "How to" section and properly configured with the matching href path.


30-30: Good consistency improvement with case standardization.

The case changes for "soulbound" and "error" improve consistency across the sidebar links by using sentence case formatting.

Also applies to: 35-35

@arcoraven arcoraven force-pushed the 06-02-docs_add_page_on_domain_verification branch from 4cb2d98 to 6d52c72 Compare June 2, 2025 08:27
@vercel vercel bot temporarily deployed to Preview – login June 2, 2025 08:27 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 2, 2025 08:27 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 2, 2025 08:27 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www June 2, 2025 08:27 Inactive
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (4)
apps/portal/src/app/knowledge-base/how-to/verify-your-team-email-domain/page.mdx (4)

11-13: Use a clear, consistent placeholder for the Team Settings URL
The current link uses https://thirdweb.com/team/~/~/settings, which may confuse readers. Consider replacing the tildes with a descriptive placeholder, e.g.:

[Team Settings](https://thirdweb.com/team/<YOUR_TEAM_ID>/settings)

40-43: Vary action verbs in the Cloudflare steps
All bullets in this section start with “Select,” which feels repetitive. For example:

- Select *DNS* > *Records*.
- Select *Add record*.
+ Click *DNS* > *Records*.
+ Click *Add record*.
🧰 Tools
🪛 LanguageTool

[style] ~43-~43: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...d domain. - Select DNS > Records. - Select Add record. [Cloudflare documentatio...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


57-60: Reduce repeated “Select” phrasing in Google Cloud DNS section
Three back-to-back bullets start the same way. You could improve readability by swapping in synonyms:

- Select *Network Services* > *Cloud DNS*.
- Select your zone.
- Select *Add record set*.
+ Open *Network Services* > *Cloud DNS*.
+ Choose your DNS zone.
+ Click *Add record set*.
🧰 Tools
🪛 LanguageTool

[style] ~59-~59: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...s* > Cloud DNS. - Select your zone. - Select Add record set. [Google Cloud docume...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


11-15: Consider explicit ordered list numbering for clarity
Although Markdown auto-numbers identical “1.” prefixes, using 1., 2., 3. can help future editors distinguish steps at a glance:

- 1. Navigate to [Team Settings](…).
- 1. Enter your domain name.
- 1. You should see instructions to add a `TXT record`.
+ 1. Navigate to [Team Settings](…).
+ 2. Enter your domain name.
+ 3. Follow the prompts to add a `TXT record`.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3adb39e and 6d52c72.

📒 Files selected for processing (2)
  • apps/portal/src/app/knowledge-base/how-to/verify-your-team-email-domain/page.mdx (1 hunks)
  • apps/portal/src/app/knowledge-base/sidebar.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/portal/src/app/knowledge-base/sidebar.tsx
🧰 Additional context used
🪛 LanguageTool
apps/portal/src/app/knowledge-base/how-to/verify-your-team-email-domain/page.mdx

[style] ~43-~43: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...d domain. - Select DNS > Records. - Select Add record. [Cloudflare documentatio...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~59-~59: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...s* > Cloud DNS. - Select your zone. - Select Add record set. [Google Cloud docume...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
apps/portal/src/app/knowledge-base/how-to/verify-your-team-email-domain/page.mdx (1)

1-8: Great overview and benefits section
The introductory section clearly communicates the upsides of verifying your team’s domain with concise bullet points. This will help users quickly grasp why they should follow these steps.

Comment on lines +27 to +32
```bash
$ dig +short -t txt _tw-<TEAM_ID>.<YOUR_DOMAIN>

# If correct, you should see this response:
"tw-verify=<YOUR_VERIFICATION_CODE>"
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Add a closing code fence to the bash snippet
The dig example is opened with ```bash but isn’t closed, which will break the markdown rendering. Please add a closing backtick fence after the example output:

 "tw-verify=<YOUR_VERIFICATION_CODE>"
+```
🤖 Prompt for AI Agents
In
apps/portal/src/app/knowledge-base/how-to/verify-your-team-email-domain/page.mdx
around lines 27 to 32, the bash code block starting with ```bash is missing a
closing code fence. Add a closing triple backtick (```) after the example output
line to properly close the code block and fix the markdown rendering.

@arcoraven arcoraven added the merge-queue Adds the pull request to Graphite's merge queue. label Jun 2, 2025
Copy link
Contributor Author

Merge activity

  • Jun 2, 8:33 AM UTC: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@arcoraven arcoraven merged commit d150ea1 into main Jun 2, 2025
20 of 21 checks passed
@arcoraven arcoraven deleted the 06-02-docs_add_page_on_domain_verification branch June 2, 2025 08:33
Copy link
Contributor

github-actions bot commented Jun 2, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.21 KB (0%) 1.3 s (0%) 211 ms (+166% 🔺) 1.5 s
thirdweb (cjs) 345.12 KB (0%) 7 s (0%) 604 ms (+2.92% 🔺) 7.6 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 99 ms (+1483.79% 🔺) 213 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 77 ms (+3933.34% 🔺) 88 ms
thirdweb/react (minimal + tree-shaking) 19.54 KB (0%) 391 ms (0%) 63 ms (+495.97% 🔺) 453 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant