track number of clickhouse insert operations #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughA new Prometheus counter metric was introduced to track the number of insert operations into ClickHouse main storage. The metrics update logic in the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant ClickHouseConnector
participant Metrics
Client->>ClickHouseConnector: InsertBlockData(data)
loop For each batch in data
ClickHouseConnector->>ClickHouseConnector: Insert batch into ClickHouse
ClickHouseConnector->>Metrics: Increment RowsInserted by batch size
ClickHouseConnector->>Metrics: Increment InsertOperations by 1
end
ClickHouseConnector-->>Client: Return result
Possibly related PRs
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
internal/storage/clickhouse.go (1)
1361-1362: LGTM: Proper per-batch metric tracking implementation.The metrics are correctly updated after successful batch operations:
ClickHouseMainStorageRowsInsertedtracks the exact number of rows in each batch (end - i)ClickHouseMainStorageInsertOperationsincrements once per batch operation- Updates occur after successful
batch.Send(), ensuring accurate trackingThe mathematical logic is sound - summing batch sizes will equal the total rows processed.
Consider standardizing the metric update approach across all insert methods. Currently:
InsertBlockDataupdates metrics per batch (new approach)insertTransactions,insertLogs,insertTracesupdate metrics once at the end (lines 275, 338, 410)For consistency, you might want to either:
- Update other methods to use per-batch tracking for better granularity
- Or document why
InsertBlockDatarequires different tracking granularity
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
internal/metrics/metrics.go(1 hunks)internal/storage/clickhouse.go(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
internal/storage/clickhouse.go (1)
internal/metrics/metrics.go (2)
ClickHouseMainStorageRowsInserted(163-166)ClickHouseMainStorageInsertOperations(158-161)
🔇 Additional comments (1)
internal/metrics/metrics.go (1)
158-161: LGTM: Well-defined metric for tracking insert operations.The new Prometheus counter metric is properly defined with appropriate naming conventions and clear help text. It complements the existing row count metric by providing visibility into the number of distinct insert operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added a new ClickHouse insert operations metric and fixed row count tracking.
What changed?
ClickHouseMainStorageInsertOperationscounter to track the total number of insert operations into ClickHouse main storageInsertBlockDatamethod to increment the row count metric within the batch processing loop instead of once at the endHow to test?
clickhouse_main_storage_insert_operationsmetric is being reported in Prometheusclickhouse_main_storage_rows_inserted_totalnow accurately reflects the actual number of rows inserted in batchesWhy make this change?
This change provides better visibility into ClickHouse database operations by tracking not just the total rows inserted but also the number of distinct insert operations. The previous implementation only counted rows at the end of the function, which could be inaccurate if the function processed data in batches. The new approach ensures metrics are incremented correctly for each batch processed.
Summary by CodeRabbit
New Features
Improvements