Created AWS Lambda node #10646
Open
Created AWS Lambda node #10646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShvaykaD
reviewed
May 20, 2024
Comment on lines
71
to
72
| .withConnectionTimeout(10000) | ||
| .withRequestTimeout(5000)) |
There was a problem hiding this comment.
These parameters should be configurable
ShvaykaD
reviewed
May 20, 2024
| AWSCredentials awsCredentials = new BasicAWSCredentials(this.config.getAccessKey(), this.config.getSecretKey()); | ||
| try { | ||
| this.client = AWSLambdaAsyncClientBuilder.standard() | ||
| .withCredentials(new AWSStaticCredentialsProvider(awsCredentials)) |
There was a problem hiding this comment.
We need to ensure that support only this type of provider is enough for all use cases.
ShvaykaD
reviewed
May 20, 2024
| private String functionName; | ||
| private String invocationType; | ||
| private String qualifier; | ||
| private Map<String, String> inputKeys; |
There was a problem hiding this comment.
mapping or funcArgumentsMapping
ShvaykaD
reviewed
May 20, 2024
Comment on lines
123
to
132
| this.config.getInputKeys().forEach((funcKey, msgKey) -> { | ||
| String patternProcessedFuncKey = TbNodeUtils.processPattern(funcKey, msg); | ||
| String patternProcessedMsgValue; | ||
| try { | ||
| String patternProcessedMsgKey = TbNodeUtils.processPattern(msgKey, msg); | ||
| patternProcessedMsgValue = msgData.get(patternProcessedMsgKey).asText(); | ||
| } catch (Exception e) { | ||
| patternProcessedMsgValue = msgKey; | ||
| } | ||
| mappings.put(patternProcessedFuncKey, patternProcessedMsgValue); |
There was a problem hiding this comment.
I think that it's better to replace the string msgKey with something like an argument in the MathNode. Let's start with Message, Metadata. Constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request description
Created AWS Lambda node.
General checklist
Back-End feature checklist