Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Widgets - Time series chart] - Implemented comparison support for new time series charts #10562

Merged
merged 5 commits into from
Apr 12, 2024

Conversation

ikulikov
Copy link
Member

@ikulikov ikulikov commented Apr 12, 2024

Pull Request description

Add comparison support to the new time series charts based on existing widgets.

image

image

Added hint "Comparison works only with historical data" - see PR 10756.

General checklist

  • You have reviewed the guidelines document.
  • Labels that classify your pull request have been added.
  • The milestone is specified and corresponds to fix version.
  • Description references specific issue.
  • Description contains human-readable scope of changes.
  • Description contains brief notes about what needs to be added to the documentation.
  • No merge conflicts, commented blocks of code, code formatting issues.
  • Changes are backward compatible or upgrade script is provided.
  • Similar PR is opened for PE version to simplify merge. Crosslinks between PRs added. Required for internal contributors only.

Front-End feature checklist

  • Screenshots with affected component(s) are added. The best option is to provide 2 screens: before and after changes;
  • If you change the widget or other API, ensure it is backward-compatible or upgrade script is present.
  • Ensure new API is documented here

Back-End feature checklist

  • Added corresponding unit and/or integration test(s). Provide written explanation in the PR description if you have failed to add tests.
  • If new dependency was added: the dependency tree is checked for conflicts.
  • If new service was added: the service is marked with corresponding @TbCoreComponent, @TbRuleEngineComponent, @TbTransportComponent, etc.
  • If new REST API was added: the RestClient.java was updated, issue for Python REST client is created.
  • If new yml property was added: make sure a description is added (above or near the property).

@ikulikov ikulikov added UI UI changes feature labels Apr 12, 2024
@ikulikov ikulikov added this to the 3.7 milestone Apr 12, 2024
@ikulikov ikulikov merged commit b453bc6 into master Apr 12, 2024
0 of 3 checks passed
@ikulikov ikulikov deleted the feature/time-series-comparison branch April 12, 2024 16:19
@vpan1n vpan1n changed the title Comparison support for new time series charts [Widgets - Time series chart] - Added comparison feature for Time series chart May 23, 2024
@vpan1n vpan1n changed the title [Widgets - Time series chart] - Added comparison feature for Time series chart [Widgets - Time series chart] - Implemented comparison support for new time series charts Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature UI UI changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant