Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font awesome lib #1475

Merged

Conversation

ArtemDzhereleiko
Copy link
Contributor

PR description

Updated font awesome lib to version 5.15 and changed icons which loaded like img to FA icon. This change allows us to make fewer requests to get image resources and fix Insights errors.

Refactoring PE and PASS to improve loading pages added lazy for image also changed img to FA icon and fixed Google Insights errors.

Link checker

The links will be checked by the build agent automatically once you create or update your PR.

You can use the following command to check the broken links locally.

docker run --rm -it --network=host --name=linkchecker ghcr.io/linkchecker/linkchecker --check-extern --no-warnings http://0.0.0.0:4000/

@ashvayka ashvayka merged commit 5a5f83f into thingsboard:master Aug 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants