Move abort results to ticket #12162
Open
Move abort results to ticket #12162
+131
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorbg
reviewed
Aug 5, 2025
danieljames-dj
force-pushed
the
abort-results
branch
from
342635e to
ee692be
Compare
gregorbg
reviewed
Aug 5, 2025
danieljames-dj
force-pushed
the
abort-results
branch
from
ee692be to
6e3ab67
Compare
gregorbg
reviewed
Aug 7, 2025
app/controllers/admin_controller.rb
Outdated
Comment on lines
44
to
45
| if @competition.results_submitted? && [email protected]_posted? | ||
| @competition.update(results_submitted_at: nil) |
There was a problem hiding this comment.
Where did these checks go? Does results_submitted_at still play a role in your new tickets system?
There was a problem hiding this comment.
Okay after some thoughts I made some changes now.
I was attempting to not reset results_submitted_at when the results are cleared, instead just aborting the ticket which allows the Delegate to resubmit. But I see that this requires much more changes - like results-not-submitted nags are depending on results_submitted_at, similarly posting dashboard is using the same, etc. So I feel it's too early to go that way.
I've now brought this method back and is reusing this to clear results submission. Sorry for causing confusions.
danieljames-dj
force-pushed
the
abort-results
branch
from
6e3ab67 to
4b0793f
Compare
gregorbg
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WRT (very rarely) abort results in case some issues are there with submission and ask the Delegate to resubmit.
Currently this flow is apparently not working because I missed to consider this during the recent works, but luckily we didn't had any case of abort so far.
I've also changed the behavior of how results can be aborted. I feel this current way is bit more cleaner and easy to understand.