Bare minimum password obfuscation #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements bare-minimum credential obfuscation. User and password must be added to a file called .siricontrolsecret, which can live in $HOME or alongside the main script. The password is b64encoded on first run.
This was written with compatibility in mind; it should work with python 2.3 and above (and only because I lazily added a set() call to deduplicate a list - otherwise it would have probably worked on 2.2 or even lower). I tested with 2.6, 2.7 and 3.6.
This is NOT a secure implementation, it's only the bare minimum to keep people from saving cleartext passwords - somebody even ended up saving their gmail password to github where everybody can see it!