Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCA / 3DSv2 compatibility for Direct and Server #163

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

saintanger
Copy link

I've pulled in here information / code from multiple issues and blogposts / opayos documentation and discussions with them. Has been tested. Hope it helps anyone else.

@judgej
Copy link
Member

judgej commented Jun 22, 2021

Do you have any documentation on how to use these changes or tips on how to test and demonstrate it? I've got this PR checked out and would like to work through it before merging. Couple of little fixes as I go along too. I think we can drop the PHP 5.6 support at this point too, since the latest Omnipay Common needs at least 7.1

@judgej
Copy link
Member

judgej commented Jun 22, 2021

When you are using a package you are extending, you don't need to rename it, even if installing it from your own repository. composer will handle fetching your own copy nicely using the repositories section of composer.json. Just mentioning that in case you didn't know.

@benjam-es
Copy link
Contributor

Possibly move the constants from src/Message/AbstractRequest.php to src/ConstantsInterface.php

@benjam-es
Copy link
Contributor

Could the protocol default to 4.00 in src/Message/AbstractRequest.php given it now has getters and setters for those needing to go back to 3.00

protected $VPSProtocol = '3.00';

@RicLeP
Copy link

RicLeP commented Aug 18, 2021

Is this still being looked at? Curious if the package supports 3D Secure V2 without this as it’ll be important going forwards.

@benjam-es
Copy link
Contributor

The package currently works, but will likely stop working when sagepay/opayo stop allowing v3

@dhavalbhavsar
Copy link

As i got email from sagepay that "3DS2 Non-compliance". So my question is there any upgradation in these package because from march 2022 it will not allow anymore.

@dhavalbhavsar
Copy link

@judgej can you please help in these case please ?

@judgej
Copy link
Member

judgej commented Aug 24, 2021

Hi, sorry, got pulled in too many other directions. I meant to look at this months ago.

Do you have links to the documentation that this is for, so we know what it is compliant with, what still needs toi be done, and can offer upgrade advice? If nothing else, I'd like to make sure the README is up-to-date with these changes.

@benjam-es
Copy link
Contributor

Hi Jason, I've used similar code as above in my PI branch to get things working, so happy to offer up some time to bounce ideas back and forth if that will help?

@judgej
Copy link
Member

judgej commented Aug 24, 2021

That's PR #165 I guess. I don't mind writing up the documentation, and I think it needs that - even if just to say this version is completely compatible with older versions. Are PR #163 and PR #165 compatible with each other? Can both be merged with a large overlap, or would that duplicate a lot of the functionality?

@dhavalbhavsar
Copy link

dhavalbhavsar commented Aug 24, 2021

@judgej here in the mail they send us two link https://developer-eu.elavon.com/docs/opayo-direct/protocol-300-400-migration-guide and https://developer-eu.elavon.com/docs/opayo-direct/api-reference

Edited: links fixed

@judgej
Copy link
Member

judgej commented Aug 24, 2021

I do miss the PDFs with everything in one document, and the ability to version them. All that documentation needs to do intio a repo really, so changes can be easily extracted.

@benjam-es
Copy link
Contributor

That's PR #165 I guess. I don't mind writing up the documentation, and I think it needs that - even if just to say this version is completely compatible with older versions. Are PR #163 and PR #165 compatible with each other? Can both be merged with a large overlap, or would that duplicate a lot of the functionality?

Mine will likely conflict as mine has a few differences, but I can tidy mine up with if/when this one is merged.

@dhavalbhavsar
Copy link

@judgej i check that PR #163 i think almost all things covered.

@judgej
Copy link
Member

judgej commented Aug 26, 2021

Thanks. Hopefully getting to it later today. Working on bringin this one up-to-date too: https://github.com/academe/SagePay-Integration/tree/opayo

Got a bit of a bug, so haven't got much done but rest since I posted this

Copy link

@dhavalbhavsar dhavalbhavsar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As i check these changes as needed as to upgrade protocol 4.0.

@calico-digital
Copy link

Hey, is there any update to this? Need to get upgraded for next month and happy to help however I can. Cheers

@dhavalbhavsar
Copy link

dhavalbhavsar commented Feb 2, 2022 via email

@benjam-es benjam-es mentioned this pull request Feb 10, 2022
@benjam-es
Copy link
Contributor

@barryvdh believe this is now covered by the pull request you just integrated, so no longer needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants