Add SagePay Direct PayPal integration #156
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still a work in progress. No tests have been set up. |
|
Some typo fixes have also been included in this pull request. |
|
I've not managed to have a good look at this one yet, but it looks like the test failures are just formatting issues - missing terminating line endings on your new files. |
eileenmcnaughton
added a commit
to eileenmcnaughton/omnipay-sagepay
that referenced
this pull request
Jan 11, 2021
I was nosying at thephpleague#156 & realised it was full of as-yet-unfixed spelling fixes. This PR just has the ones in the tests directory from that PR
Merged
|
I pulled out a few on these into a separate PR since this would be more readable with less changes & there is a lot of unrelated cleanup in it #162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request that adds the PayPal integration that was built as part of the oilstone/omnipay-sagepay fork, however that fork cannot be merged back in due to changes in the composer package definitions.
This is still a work in progress and will still need to be tested but it is a start to adding proper PayPal integration into this package.