Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only make FAT bin if TARGET_ARCHS > 1 #768

Merged
merged 1 commit into from May 16, 2024
Merged

Conversation

L1ghtmann
Copy link
Member

@L1ghtmann L1ghtmann commented Sep 8, 2023

What does this implement/fix? Explain your changes.

  • Keeps single-arch projects single-arch thin bins

Does this close any currently open issues?

No

Any relevant logs, error output, etc?

Any other comments?

See convo with Daniel/Leptos in the Theos Discord (#theos-general)

Where has this been tested?

Operating System:

Linux (WSL)

Platform:

Target Platform:

Toolchain Version:

SDK Version:

@leptos-null
Copy link
Member

Adding the Discord thread mentioned in the PR for reference: https://discord.com/channels/811490080278839327/811494949849661490/1149833620819816559

Copy link
Member

@leptos-null leptos-null left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xcode also appears to have this behavior.
As does clang, if you list only 1 -arch.

@leptos-null leptos-null merged commit 2e38194 into theos:master May 16, 2024
@L1ghtmann L1ghtmann deleted the lipo-fix branch May 16, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants