Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent bundle absolute LC_ID_DYLIB #721

Merged
merged 6 commits into from May 16, 2024

Conversation

L1ghtmann
Copy link
Member

@L1ghtmann L1ghtmann commented Apr 14, 2023

What does this implement/fix? Explain your changes.

Specifies runtime location as install_name for bundles when linking to avoid using an absolute path

Does this close any currently open issues?

Appears to resolve #720

Any relevant logs, error output, etc?

Any other comments?

Before:

          cmd LC_ID_DYLIB
      cmdsize 96
         name /home/lightmann/vinyl/.theos/obj/arm64/VinylPrefs.bundle/VinylPrefs (offset 24)

After:

          cmd LC_ID_DYLIB
      cmdsize 88
         name /var/jb/Library/PreferenceBundles/VinylPrefs.bundle/VinylPrefs (offset 24)

Where has this been tested?

Operating System:

Linux (WSL) + iP7 iOS 15.4.1 palera1n

Platform:

Target Platform:

Toolchain Version:

SDK Version:

@L1ghtmann L1ghtmann changed the title Use relative install_name path for bundles (prevents absolute LC_ID_DYLIB) Prevent bundle absolute LC_ID_DYLIB Nov 8, 2023
Copy link
Member

@leptos-null leptos-null left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Is there a reason we would like to expose $(THEOS_CURRENT_INSTANCE)_DYNAMIC_LIBRARY? I don't see this variable anywhere else.

@L1ghtmann
Copy link
Member Author

Interesting. Seems its purpose is to allow non-dynamic bundles...234e1c4

@leptos-null
Copy link
Member

My bad, this variable is unrelated to this PR 👍

@leptos-null leptos-null merged commit e06507d into theos:master May 16, 2024
@L1ghtmann L1ghtmann deleted the rel-bundle-loadcmd branch May 16, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants