Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix edit menu items #160

Merged
merged 1 commit into from
Jun 15, 2017
Merged

fix edit menu items #160

merged 1 commit into from
Jun 15, 2017

Conversation

chris48s
Copy link
Collaborator

Steps to reproduce bug:

  • Start application
  • Click any item in the Edit menu
  • Application will throw ReferenceError: mainWindow is not defined

Looks like I broke this in PR #140 when I removed the mainWindow variable from the global scope but forgot to update these menu items. I think this is more correct anyway as previously these operations were probably being applied to whatever window was most recently created instead of the currently active window.

@chris48s chris48s mentioned this pull request Jun 14, 2017
@Stephen-Gates
Copy link
Contributor

Hi @chris48s, thanks for all your contributions. The ODI Australian Network has big plans for Comma Chameleon.
https://ask.theodi.org.au/t/a-vision-for-comma-chameleon/473

@pezholio pointed me in your direction.

Contact me via
Twitter @SGatesHQ
Email: StephenG @ ODIQueensland.org.au

to see the draft spec.

@quadrophobiac quadrophobiac merged commit fb3d56d into theodi:master Jun 15, 2017
@quadrophobiac
Copy link
Collaborator

Hi @chris48s - thanks for working on this. I've confirmed that this patch fixes the majority of commands in the edit menu. The one exception is copy, for which I've opened a separate ticket #164 as I suspect its not related to the fix you've made here.
I'd also like to echo Stephen's sentiment - thanks so much for the consistent contributions to this repo! I wanted to let you know that you have push access on this repository, so you don't have to work in forks for any future contributions you'd like to make to this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants