Copy functionality not operating

[quadrophobiac]

Steps to reproduce bug:

Utilise shortcut for copy (CMD/CTRL+V) or click Menu>Edit>Copy.
Attempt to paste to empty cell (no content should be pasted).
Other related menu items like CUT and PASTE do function as anticipated .

[chris48s]

Can you clarify this? I may have misunderstood.

Are you saying that if you copy a 'blank' cell (i.e: a cell containing the empty string) and paste it over a cell that has content in it, the expected behaviour should be that the cell retains its existing content?

In that situation, I would expect this to do what it does now (i.e: overwrite the content of the target cell with empty string).

[quadrophobiac]

Hi @chris48s

What I described should have stipulated 'select a cell with content, select or keyboard shortcut for copy, then paste to an empty cell.
When I do this nothing is copied and pasted between cells. I can now add some additional steps to reproduce

• Select a cell with content, EG A2
• Select CUT
• Paste should only function for the cell that was selected. If you use paste (menu or shortcut) on cell A2 the cut content will be replaced. If you attempt to paste to an empty cell (E3 for examples sake) it will not paste.

[chris48s]

so this doesn't work for you then?

[Stephen-Gates]

Just downloaded the latest comma chameleon, started app, in A1 pressed Cmd+C

[chris48s]

Just to clarify, that gif is recorded with 897f235 which isn't (yet) a tagged release

[quadrophobiac]

@Stephen-Gates pretty much what Chris said RE why downloaded packages do not do this yet.
@chris48s I'm running my comma chameleon with npm start, in case that's relevant (I notice that in that gif your menu bar says comma chameleon rather than electron). Is that gif made from the most recent master of this repo? In answer to your question - no I cannot replicate what you do in the gif

[chris48s]

I'm running my comma chameleon with npm start

Same

I notice that in that gif your menu bar says comma chameleon rather than electron

It always says Comma Chameleon there for me. I wonder if that's a platform thing.. What OS are you running on?

Is that gif made from the most recent master of this repo

Yep

I guess the other thing worth looking at would be dependency versions. I've got 0.16.1 of HandsOnTable and 1.4.13 of electron-prebuilt (probably the most obvious 2 to look at in this situation). What are you running?

[quadrophobiac]

Hey @chris48s

I've got the same dependency versions for both HandsOnTable and electron-prebuilt as you.
The difference in visual appearance mystifies me. This is what I get on npm start on Mac OS Sierra. Thing is I can remember this visual being the same for prior Mac OS versions

[chris48s]

OK. I'm running Ubuntu, which is what that Gif record was from. I can also test a Windows build if necessary but I don't use Macs.

If you git checkout 69a9aef, do the copy/cut/paste actions work with that revision?

Separately, I'm not sure if the title saying "Electron" or "Comma Chameleon" is:

• related to this,
• an unrelated issue, or
• a red herring.

Mine has always said Comma Chameleon in the title bar - see these screenshots from ~6 months ago:
#129 (comment)
#128 (comment)

That's also what I get if I grab a Windows build:

This recent-ish screenshot posted by @Stephen-Gates seems to show a build on MacOS showing the title as "Comma Chameleon":
#152

..but as I say, I'm unclear if this is related to the topic issue or not?

[quadrophobiac]

Hey @chris48s

Checked out 69a9aef - can confirm that I can now do the process you detailed in the previous GIF. Keyboard shortcuts do not work but the edit menu functions as expected for cut | copy and paste.

The Title Bar stuff is probably a red herring to this issue, and maybe not consequential overall, because for the end user that field is populated using the "name" field from package.json. I do wonder if it relates to npm problems I've had on my local machine though.

[chris48s]

OK so 69a9aef is the commit where we modified cut/copy/paste etc such that they are implemented using the HandOnTable functions. If 69a9aef works for you then that can't be the issue - it must be something else that has changed since.

I guess the next thing I would do is stick a console.log() statement in here https://github.com/theodi/comma-chameleon/blob/master/main/menu.js#L171 and here https://github.com/theodi/comma-chameleon/blob/master/renderer/index.js#L120 then do a 'cut' and see if both of them execute.. and so on for 'paste' to see if I can track down the problem. Unfortunately I can't reproduce in any environment so my results will probably be different to yours :(

I wonder if the Undo/Redo/Select All functions work for you?