Refactor measure module #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Rename `density` and `model` arguments to `true` and `approx` to be more general. Also `model` argument is later used to specify AtomicGaussianDensity or MolecularGaussianDensity instances, which is different from the use of `model` here. 2. Add black changes 3. Polish docstrings to be more consistent and concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
densityandmodelarguments totrueandapproxtobe more general. Also
modelargument is later used to specifyAtomicGaussianDensity or MolecularGaussianDensity instances, which is
different from the use of
modelhere.@Ali-Tehrani, feel free to let me know what you think of these changes. There are also two
#TODOitems in this module, which would be good to address.