fix: make badge class reactive #1416
Conversation
|
@koplas is attempting to deploy a commit to the Themesberg Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe changes to the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Can you add a simple example to the doc page? |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (1)
src/routes/docs/components/badge.md (1)
256-258: Add a more descriptive introduction.The introduction to the "Dynamic color" section is very brief. Consider adding more details to explain the use case and benefits of dynamic color changes.
-The color can be changed dynamically. +The color of the Badge component can be changed dynamically to enhance interactivity and provide visual feedback based on user actions or other events.
| ```svelte example class="flex flex-wrap gap-4" hideResponsiveButtons | ||
| <script> | ||
| import { Badge } from 'flowbite-svelte'; | ||
|
|
||
| setInterval(handleHover, 500); | ||
|
|
||
| let color = 'primary'; | ||
| function handleHover() { | ||
| color = color === 'primary' ? 'dark' : 'primary'; | ||
| } | ||
| </script> | ||
|
|
||
| <Badge large {color}>Blinking badge</Badge> | ||
| ``` |
There was a problem hiding this comment.
Ensure proper cleanup of the interval.
The setInterval function is used to toggle the color every 500 milliseconds, but there is no cleanup for the interval when the component is destroyed. This can lead to memory leaks.
Apply this diff to ensure proper cleanup of the interval:
<script>
import { Badge } from 'flowbite-svelte';
- setInterval(handleHover, 500);
+ let interval;
+ onMount(() => {
+ interval = setInterval(handleHover, 500);
+ });
+ onDestroy(() => {
+ clearInterval(interval);
+ });
let color = 'primary';
function handleHover() {
color = color === 'primary' ? 'dark' : 'primary';
}
</script>Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ```svelte example class="flex flex-wrap gap-4" hideResponsiveButtons | |
| <script> | |
| import { Badge } from 'flowbite-svelte'; | |
| setInterval(handleHover, 500); | |
| let color = 'primary'; | |
| function handleHover() { | |
| color = color === 'primary' ? 'dark' : 'primary'; | |
| } | |
| </script> | |
| <Badge large {color}>Blinking badge</Badge> | |
| ``` | |
| ```svelte example class="flex flex-wrap gap-4" hideResponsiveButtons | |
| <script> | |
| import { Badge } from 'flowbite-svelte'; | |
| import { onMount, onDestroy } from 'svelte'; | |
| let interval; | |
| onMount(() => { | |
| interval = setInterval(handleHover, 500); | |
| }); | |
| onDestroy(() => { | |
| clearInterval(interval); | |
| }); | |
| let color = 'primary'; | |
| function handleHover() { | |
| color = color === 'primary' ? 'dark' : 'primary'; | |
| } | |
| </script> | |
| <Badge large {color}>Blinking badge</Badge> | |
| ``` |
|
Thank you for your contribution. |
Closes #1400
📑 Description
This pull requests fixes a regression that prevented from changing the badge color. It also removes unused code and formats the file.
Status
✅ Checks
Summary by CodeRabbit
New Features
Style
Refactor
badgeClassvariable to ensure it updates correctly with changes in dependencies.