Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update figures test fixtures test data imports #992

Merged
merged 5 commits into from
Feb 6, 2025
Merged

Update figures test fixtures test data imports #992

merged 5 commits into from
Feb 6, 2025

Conversation

mphstudios
Copy link
Member

@mphstudios mphstudios commented Jan 29, 2025 •
edited
Loading

Fixed

  • Use EMS import statements for figures test data

Changed

  • Use fs to read figures fixture data from JSON files

@mphstudios mphstudios requested a review from cbutcosk January 29, 2025 23:38
@mphstudios mphstudios force-pushed the fix/figure-fixtures-data branch from 392ba6f to 9ffa10f Compare January 29, 2025 23:41
@mphstudios mphstudios marked this pull request as draft January 31, 2025 19:31
@mphstudios mphstudios marked this pull request as ready for review February 6, 2025 23:33
@mphstudios mphstudios merged commit 3f61785 into main Feb 6, 2025
@mphstudios mphstudios deleted the fix/figure-fixtures-data branch February 6, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbutcosk cbutcosk cbutcosk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mphstudios @cbutcosk