Add Bookworm to theforeman.org #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Oct 23, 2024
| @@ -100,6 +101,26 @@ echo "deb http://deb.theforeman.org/ plugins {{page.version}}" | sudo tee -a /et | |||
| {% endhighlight %} | |||
| </div> | |||
|
|
|||
| <div class="quickstart_os quickstart_os_debian12"> | |||
| <p> | |||
| Enable Puppet's 8.x repository: | |||
There was a problem hiding this comment.
I see the others use Puppet 7 and there are Puppet 7 packages for Bookworm. Should we first update everything to Puppet 8 or keep this consistent and use Puppet 7?
There was a problem hiding this comment.
I've seen the same and my brain went "well, we'll end up on p8 anyway, so lets use p8 and update the rest later (or before)"
I can submit a s/7/8/ PR separately and then rebase this ontop?
There was a problem hiding this comment.
I can submit a
s/7/8/PR separately and then rebase this ontop?
I think that'd be great.
ekohl
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.