Add nightly for each repository release stream

[ehelms]

This change will allow controlling for what OSes a given release from our release jobs, for nightly, and align it with a numerical release. Right now, we store in Jenkins the OSes nightly supports and then we iterate and call the build_stage_repository script [1]. By having the nightly releases captured here, our CI can instead call VERSION='nightly' PROJECT=<project> ./generate_stage_repositories and allow configuration inside this repository to drive what is generated.

In a similar fashion, we can make use of a single rsync script to stagingyum to handle uploads for nightly and releases in the same way without having to keep CI and this repository in sync. See theforeman/jenkins-jobs#369.

[1] https://github.com/theforeman/jenkins-jobs/blob/master/theforeman.org/pipelines/release/pipelines/foreman-rpm.groovy#L69-L73

[ekohl]

We don't have rc1 in nightly. I'm not sure what a valid FULLVERSION would be. For example, in our release pipeline we pass FULLVERSION as the expected version and that would mean it expects nightly.0-rc1 in /usr/share/foreman*/VERSION. Perhaps it should just not be set at all?

[ehelms]

We don't have rc1 in nightly. I'm not sure what a valid FULLVERSION would be. For example, in our release pipeline we pass FULLVERSION as the expected version and that would mean it expects nightly.0-rc1 in /usr/share/foreman*/VERSION. Perhaps it should just not be set at all?

For now I shortened it to nightly. Right now this appears to be forced by https://github.com/theforeman/theforeman-rel-eng/blob/master/settings#L25-L29 and I wouldn't want to relax this for releases. Whereas having this ability to use scripts in all versions including nightly is strong for centralizing our scripts. Perhaps we take this version as is and keep iterating if FULLVERSIOn for nightly becomes tricky with other workflows?

[ekohl]

In #330 I made an effort to make some variables optional, which makes the files more logical.

[ehelms]

With #330 merged, what are you expecting to change here?

[ekohl]

I think we can now drop FULLVERSION in all of these files. The flows that need it shouldn't run and otherwise properly error out.

[ehelms]

I think we can now drop FULLVERSION in all of these files. The flows that need it shouldn't run and otherwise properly error out.

Cleaned up, and seems to be working from my test scenarios on scripts.

[ekohl]

I should have caught this in the previous review, but more simplifications are possible.

[ekohl]

We set this by default:

theforeman-rel-eng/releases/client/settings

Line 3 in 6a9a8a3

FOREMAN_VERSION=$VERSION

Suggested change

FOREMAN_VERSION='nightly'

[ekohl]

Candlepin doesn't have a Foreman version:

theforeman-rel-eng/releases/candlepin/settings

Line 4 in 6a9a8a3

FOREMAN_VERSION='none'

Suggested change

FOREMAN_VERSION='nightly'

[ekohl]

I'd prefer a solution similar to client where in releases/plugins/settings we set FOREMAN_VERSION=$VERSION and be done with it.

Suggested change

FOREMAN_VERSION='nightly'

[ekohl]

As said above: we can set it by default (and sort the file alphabetically):

Suggested change

	PACKAGING_SUBDIR="packages/plugins"
	OSES="el8"
	FOREMAN_VERSION=$VERSION
	OSES="el8"
	PACKAGING_SUBDIR="packages/plugins"

[ekohl]

Wouldn't you still need a release/plugins/nightly/settings file, since it will error out if it doesn't exist? By now that needs OSES="el8 el9".

[ekohl]

Last one, I promise ;)

[evgeni]

Glad I didn't promise anything