add support for managing individual plugin versions #1188
+383
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i kept the parameter documentation in the same style for each class, as opposed to using edit: it seems this decision causes some tests to fail as the deprecated documentation style is no longer recognized as valid. how do we proceed here? |
UiP9AV6Y
force-pushed
the
feature_plugin_ensure_version
branch
from
04a836c to
1d04c0e
Compare
currently on the remote_execution/cockpit plugin class has support for managing the plugin version. all other plugins are tied to the `foreman::plugin_version`. this change adds the same `ensure` parameter to all plugin classes allowing for granular state management.
UiP9AV6Y
force-pushed
the
feature_plugin_ensure_version
branch
from
1d04c0e to
5527093
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently on the remote_execution/cockpit plugin class has support for managing the plugin version. all other plugins are tied to the
foreman::plugin_version. this change adds the sameensureparameter to all plugin classes allowing for granular state management.