-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install oauth gem on puppet agent #1077
base: master
Are you sure you want to change the base?
Conversation
puppet6 aio bundles the oauth gem but it is not bundled with puppet7 aio. Most of the native types in this module require this gem to be present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is invalid. We have foreman::providers already to take care of this. That installs puppet-agent-oauth
which installs the gem in the puppetserver gem environment. However, when you upgrade from Puppetserver 6 to 7 you need to reinstall it. Our installer has a hook to do this automatically.
@ekohl I was ignorant to the existence of [jhoblitt@foreman ~]$ repoquery --list puppet-agent-oauth-0.5.5-1.el7.noarch
/usr/share/foreman-installer/gems/oauth-0.5.5.gem Which doesn't solve my issue as that gem does not end up being installed as part of the puppet agents env. I am not using the types in this package via the installer but as part of regular puppet agent runs. |
That's handled via It really is a hack, but native packaging was hard and it works OK-ish. Except when puppet-agent changes its Ruby version, like with Puppet's major versions. |
That rpm is already installed on my production puppet6 puppetservers, so it would need to be |
What about installing |
puppet6 aio bundles the oauth gem but it is not bundled with puppet7 aio. Most of the native types in `theforeman/foreman` require this gem to be present. See: theforeman/puppet-foreman#1077
puppet6 aio bundles the oauth gem but it is not bundled with puppet7 aio. Most of the native types in `theforeman/foreman` require this gem to be present. See: theforeman/puppet-foreman#1077
puppet6 aio bundles the oauth gem but it is not bundled with puppet7 aio. Most of the native types in `theforeman/foreman` require this gem to be present. See: theforeman/puppet-foreman#1077
puppet6 aio bundles the oauth gem but it is not bundled with puppet7 aio. Most of the native types in `theforeman/foreman` require this gem to be present. See: theforeman/puppet-foreman#1077
puppet6 aio bundles the oauth gem but it is not bundled with puppet7 aio. Most of the native types in `theforeman/foreman` require this gem to be present. See: theforeman/puppet-foreman#1077
While I like the idea, we bumped it to 0.5.10 in current versions. I think it should provide a symlink |
puppet6 aio bundles the oauth gem but it is not bundled with puppet7 aio. Most of the native types in `theforeman/foreman` require this gem to be present. See: theforeman/puppet-foreman#1077
I migrated my production sites from 6 -> 7 a month ago, so this PR is no longer relevant for me. Should we leave it open for someone else to potentially pick up or close it? |
This may become relevant again when Puppet 8 comes out so I'd leave it open for now. |
puppet6 aio bundles the oauth gem but it is not bundled with puppet7
aio. Most of the native types in this module require this gem to be
present.