Add more tests #313
Draft
Add more tests #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehelms
reviewed
Jan 15, 2021
ehelms
reviewed
Jan 15, 2021
| if ca_resource && ca_resource.class.to_s != 'Puppet::Type::Ca' | ||
| raise ArgumentError, "Expected Ca resource, got #{ca_resource.class} #{ca_resource.inspect}" | ||
| if ca_resource | ||
| # rspec-puppet presents Puppet::Resource instances |
There was a problem hiding this comment.
What does this comment mean? Is this like "we have to do the next line because of our test infrastructure" ?
|
Splitting the PR: #422 |
When testing the relations in rspec-puppet, it turns out that there are other classes and they don't match which breaks tests.
|
Rebased just to see how much of this was still remaining and left out the type tightening. |
ekohl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commits for details.