Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #32611: Drop Puppet 5 support #336

Closed
wants to merge 1 commit into from

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented May 17, 2021

No description provided.

@ehelms
Copy link
Member Author

ehelms commented May 17, 2021

Testing update needed prior to -- theforeman/jenkins-jobs#65

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the README up to date (https://github.com/theforeman/kafo#requirements).

class kafo_configure(
Boolean $add_progress = $::kafo_add_progress,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're dropping this, please also drop all code for it:

#{add_progress}

def add_progress
%{$kafo_add_progress=#{!KafoConfigure.verbose}}
end

(and the tests)

@ekohl
Copy link
Member

ekohl commented May 17, 2021

Also, I'd like to hold this off. Doing another major release is just a pain and we don't really gain a lot by doing so now, right?

@ehelms
Copy link
Member Author

ehelms commented May 17, 2021

Also, I'd like to hold this off. Doing another major release is just a pain and we don't really gain a lot by doing so now, right?

If not now, then when? If we plan to drop this support, we benefit ourselves from doing it across the board and at the start of a release. The "major" bump aspect of it is pretty easy to orchestrate. What do you see as the pain ?

@ekohl
Copy link
Member

ekohl commented May 18, 2021

Cherry picks become more work.

@ekohl
Copy link
Member

ekohl commented May 5, 2023

In #354 I went a step further and also cleaned up the progress bar support.

@ekohl ekohl closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants