-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #32611: Drop Puppet 5 support #336
Conversation
Testing update needed prior to -- theforeman/jenkins-jobs#65 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the README up to date (https://github.com/theforeman/kafo#requirements).
class kafo_configure( | ||
Boolean $add_progress = $::kafo_add_progress, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're dropping this, please also drop all code for it:
kafo/lib/kafo/puppet_command.rb
Line 76 in a45b1eb
#{add_progress} |
kafo/lib/kafo/puppet_command.rb
Lines 82 to 84 in a45b1eb
def add_progress | |
%{$kafo_add_progress=#{!KafoConfigure.verbose}} | |
end |
(and the tests)
Also, I'd like to hold this off. Doing another major release is just a pain and we don't really gain a lot by doing so now, right? |
If not now, then when? If we plan to drop this support, we benefit ourselves from doing it across the board and at the start of a release. The "major" bump aspect of it is pretty easy to orchestrate. What do you see as the pain ? |
Cherry picks become more work. |
In #354 I went a step further and also cleaned up the progress bar support. |
No description provided.