fix 3.9 jenkins job definitions #385
Conversation
evgeni
changed the title
|
|
||
| def foreman_client_distros = [ | ||
| 'el9', | ||
| 'el8', | ||
| 'el7', | ||
| 'sles12' |
There was a problem hiding this comment.
I didn't realize we'd effectively drop sles12 this way. I wonder if we could somehow restore this at some point, like syncing from OBS.
There was a problem hiding this comment.
copr can build for sles, so we could… just build it, properly.
There was a problem hiding this comment.
It's not listed in nightly, which is the source for this:
There was a problem hiding this comment.
I did a more careful analysis of where it went wrong, but I can't explain it. It should all be covered. The PR was also made on top of a commit that had the correct script. The only thing I can think of is that it was made against an older version and then rebased before submitted as a PR.
| @@ -1 +1 @@ | |||
| [] | |||
| - '3.9' | |||
There was a problem hiding this comment.
I'd have expected this line to add this:
Line 24 in b993393
| @@ -20,3 +20,4 @@ | |||
| version: | |||
| - '4.9' | |||
| - '4.10' | |||
| - '4.11' | |||
There was a problem hiding this comment.
This should be covered:
Line 26 in b993393
| @@ -13,6 +13,7 @@ | |||
| minor: | |||
| - '7' | |||
| - '8' | |||
| - '9' | |||
There was a problem hiding this comment.
This is called out as a manual TODO:
Lines 31 to 32 in b993393
| @@ -7,6 +7,7 @@ | |||
| version: | |||
| - '4.9' | |||
| - '4.10' | |||
| - '4.11' | |||
There was a problem hiding this comment.
This should be covered:
Line 20 in b993393
| @@ -1,12 +1,11 @@ | |||
| def foreman_version = '3.9' | |||
| def git_branch = "${foreman_version}-stable" | |||
| def stage_source = 'copr' | |||
| def stage_source = 'stagingyum' | |||
There was a problem hiding this comment.
|
|
||
| def foreman_client_distros = [ | ||
| 'el9', | ||
| 'el8', | ||
| 'el7', | ||
| 'sles12' |
There was a problem hiding this comment.
It's not listed in nightly, which is the source for this:
|
yeah, I have no idea how this happened. |
Fixes: 55c177c