Skip to content

Fixes #38708 - Slow and unresponsive settings page #10673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fixes #38708 - Slow and unresponsive settings page #10673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions webpack/assets/javascripts/react_app/components/SettingsTable/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';
import { useSelector } from 'react-redux';
import PropTypes from 'prop-types';

import { Skeleton } from '@patternfly/react-core';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use our SkeletonLoader instead?

import { selectSettingsByCategory } from '../SettingRecords/SettingRecordsSelectors';

import SettingsTable from './SettingsTable';
Expand All @@ -11,7 +11,11 @@
selectSettingsByCategory(props.category)(state)
);

return <SettingsTable settings={settings} />;
const documentLoaded = () => document.readyState === 'complete';

if (documentLoaded()) return <SettingsTable settings={settings} />;

return <Skeleton width="100%" height="70vh" />;

Check warning on line 18 in webpack/assets/javascripts/react_app/components/SettingsTable/index.js

View workflow job for this annotation

GitHub Actions / test (13, 3.0, 18) 

You have a misspelled word: 70vh on String

Check warning on line 18 in webpack/assets/javascripts/react_app/components/SettingsTable/index.js

View workflow job for this annotation

GitHub Actions / test (13, 2.7, 18) 

You have a misspelled word: 70vh on String

Check warning on line 18 in webpack/assets/javascripts/react_app/components/SettingsTable/index.js

View workflow job for this annotation

GitHub Actions / test (13, 3.0, 22) 

You have a misspelled word: 70vh on String

Check warning on line 18 in webpack/assets/javascripts/react_app/components/SettingsTable/index.js

View workflow job for this annotation

GitHub Actions / test (13, 2.7, 22) 

You have a misspelled word: 70vh on String
};

WrappedSettingsTable.propTypes = {
Expand Down
Loading