Fixes #38108 - As a user I want to invalidate tokens for self(UI) #10405
Conversation
girijaasoni
force-pushed
the
38108
branch
2 times, most recently
from
f3234ce to
95f093f
Compare
| <h1>{__('JWT Tokens')}</h1> | ||
| <p> | ||
| {__( | ||
| 'By invalidating tokens,you will no longer be able to register hosts by using their JWTs.' |
There was a problem hiding this comment.
| 'By invalidating tokens,you will no longer be able to register hosts by using their JWTs.' | |
| 'By invalidating your JSON Web Tokens (JWTs), you will no longer be able to register hosts by using your existing JWTs.' |
| process_success( | ||
| :success_msg => _('Successfully invalidated JWTs for %s.') % @user.login | ||
| ) | ||
| unless editing_self? |
There was a problem hiding this comment.
Why this change? Why not to have same response as before?
webpack/assets/javascripts/react_app/components/users/JwtTokens/JwtTokens.js
Show resolved
Hide resolved
| APIActions.patch({ | ||
| url: `/users/${userId}/invalidate_jwt`, | ||
| key: `INVALIDATE-JWT`, | ||
| successToast: () => |
There was a problem hiding this comment.
What if the call is not successful?
There was a problem hiding this comment.
That will not happen, Like we discussed in the first story PR, there will be no case when invalidation won't work. I can add a safety failed toast, what do you think?
There was a problem hiding this comment.
What if user was logged out meanwhile? The Rails will respond with 501
There was a problem hiding this comment.
we are sending :ok status at all times, ref
I think I can add a safety error toast too, what do u think?
There was a problem hiding this comment.
we are sending :ok status at all time
That's not true. You do in>your< controller, but what if there is a problem on the network, DNS, or somewhere else? How do you handle that error?
| import { APIActions } from '../../../redux/API'; | ||
| import { translate as __ } from '../../../common/I18n'; | ||
|
|
||
| const JwtTokens = ({ userId }) => { |
There was a problem hiding this comment.
What if the userID is not set?
| test "User should be able to invalidate jwt for self" do | ||
| User.current = users(:one) | ||
| user = User.current | ||
| FactoryBot.build(:jwt_secret, token: 'test_jwt_secret', user: user) |
There was a problem hiding this comment.
| FactoryBot.build(:jwt_secret, token: 'test_jwt_secret', user: user) | |
| FactoryBot.create(:jwt_secret, token: 'test_jwt_secret', user: user) |
With build the object is not saved in the database, making the assertion pass even if the action was not performing correctly
girijaasoni
force-pushed
the
38108
branch
2 times, most recently
from
e2e14dc to
d19a69c
Compare
No description provided.