Update CONTRIBUTING with acceptance testing steps #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
reviewed
Feb 24, 2023
moduleroot/CONTRIBUTING.md.erb
Outdated
| This will make sure all needed modules are prepared to be used in a VM. | ||
|
|
||
| 4. Run the tests: | ||
| - `BEAKER_HYPERVISOR=vagrant_libvirt bundle exec rspec` |
There was a problem hiding this comment.
should this be bundle exec rake beaker?
rspec didn't work for me, while rake beaker does
There was a problem hiding this comment.
Weird, I've never run rake beaker, but rspec :/
There was a problem hiding this comment.
It might very well be my setup :)
There was a problem hiding this comment.
The intended command is rake beaker for the whole acceptance test suite. That already depends on spec_prep so that isn't a separate step.
If you just run rspec then you may also run unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ekohl, here is my two cents which helped me (thanks to you ofc) with running acceptance tests locally.
I'd be glad for any additional suggestions, improvements, etc.
I'd also prefer a link from
READMEtoCONTRIBUTING, but I'm not sure it's doable from this repo.