Create a new guide for provisioning virtual machines (2 of 3) #3608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lennonka
added
Needs tech review
Lennonka
commented
Jan 23, 2025
| <productnumber>{ProjectVersion}</productnumber> | ||
| <abstract> | ||
| <para> | ||
| TODO |
There was a problem hiding this comment.
Note to self: TODO
"Overture is composed last."
guides/common/modules/con_provisioning-virtual-machines-on-kubevirt.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/snip_warning-destroy-vm-on-host-delete.adoc
Outdated
Show resolved
Hide resolved
Comment on lines
+5
to
+8
|
|
||
| = {ProvisioningVirtualDocTitle} | ||
|
|
||
| // This guide is not ready for stable releases |
There was a problem hiding this comment.
question: Do you have reasons to believe that the guide would not work for unstable and/or foreman-el/foreman-deb?
There was a problem hiding this comment.
It probably should work for all builds, since images are not part of Katello. However, right now I'm not sure it works at all and I would prefer to revisit this question later :))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Splitting Provisioning hosts into 3 new guides:
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
To mitigate pain points identified in SAT-26089 comments (public).
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Reviewers, please, focus on the title and heading structure in this PR. Using preview first is highly recommended.
Checklists
Please cherry-pick my commits into: N/A