AutoClimb State Machine by SyntaxBreak · Pull Request #193 · thedropbears/pyrebuilt

SyntaxBreak · 2026-03-01T05:55:32Z

LucienMorey

more tings I meant to review last night

DannyPomeranian · 2026-03-03T23:11:19Z

@auscompgeek @LucienMorey are the checks failing because I am not injecting the climber state machine into auto properly?

auscompgeek · 2026-03-05T06:12:24Z

are the checks failing because I am not injecting the climber state machine into auto properly?

What's confusing about the error message to you @DannyPomeranian?

FAILED tests/pyfrc_test.py::test_disabled - magicbot.inject.MagicInjectError: Component Spin while forward for 3m has variable autoclimber (type <class 'controllers.autoclimber.AutoClimber'>), which is absent from robot

DannyPomeranian · 2026-03-05T08:19:29Z

are the checks failing because I am not injecting the climber state machine into auto properly?

What's confusing about the error message to you @DannyPomeranian?
FAILED tests/pyfrc_test.py::test_disabled - magicbot.inject.MagicInjectError: Component Spin while forward for 3m has variable autoclimber (type <class 'controllers.autoclimber.AutoClimber'>), which is absent from robot

@auscompgeek is it because im not making an instance of the auto state machine in robotpy?

DannyPomeranian · 2026-03-05T08:32:42Z

nvm its the radio access point naming problem all over again 🤦

DannyPomeranian · 2026-03-05T08:33:20Z

ICH BIN SEHR DUMM

SyntaxBreak · 2026-03-06T03:58:54Z

ICH BIN SEHR DUMM

ja du bist ein dummkopf

auscompgeek · 2026-03-10T09:10:29Z

    return Translation2d(FIELD_LENGTH - t.x, t.y)


+def rotational_flip_translation2d(t: Translation2d):


I think this should just be the implementation of field_flip_translation2d. If necessary field_flip_rotation2d should also be fixed :)

The field flip method is used as is (or as was, just a flip over the y-axis, or opposite side of the field lengthways) by other points, do you think that these can be changed also?

Although, actually, if they worked on the previous method they would have been halfway through the y-axis of the field anyway so it would work either way.

As in if you've fixed a real bug here, then the buggy field_flip_translation2d should be replaced.

…nstead of manual timing

…hine

DannyPomeranian · 2026-03-12T05:21:53Z

oops davo dont eat me it was a mouse slip

DannyPomeranian force-pushed the make_auto_climb_logic branch from aeaa27c to f508e21 Compare March 1, 2026 06:14

auscompgeek reviewed Mar 1, 2026

View reviewed changes

Comment thread components/climber.py Outdated

Comment thread controllers/autoclimber.py Outdated

DannyPomeranian force-pushed the make_auto_climb_logic branch 2 times, most recently from f37a51d to 84c076a Compare March 1, 2026 10:01

LucienMorey reviewed Mar 1, 2026

View reviewed changes

Comment thread controllers/autoclimber.py

SyntaxBreak linked an issue Mar 1, 2026 that may be closed by this pull request

Automate the climb sequence for both auto and endgame #126

Closed

SyntaxBreak marked this pull request as draft March 1, 2026 11:35

LucienMorey reviewed Mar 1, 2026

View reviewed changes

Comment thread utilities/game.py Outdated

Comment thread utilities/game.py Outdated

Comment thread controllers/autoclimber.py

SyntaxBreak marked this pull request as ready for review March 1, 2026 22:39

SyntaxBreak force-pushed the make_auto_climb_logic branch from 67368f7 to 32b3c68 Compare March 2, 2026 07:58

LucienMorey reviewed Mar 3, 2026

View reviewed changes

Comment thread controllers/autoclimber.py

LucienMorey reviewed Mar 3, 2026

View reviewed changes

Comment thread utilities/game.py Outdated

LucienMorey reviewed Mar 3, 2026

View reviewed changes

Comment thread controllers/autoclimber.py Outdated

DannyPomeranian force-pushed the make_auto_climb_logic branch from a5c5eda to 92fe3ba Compare March 3, 2026 11:51

DannyPomeranian requested review from LucienMorey and auscompgeek March 3, 2026 11:54

auscompgeek requested changes Mar 3, 2026

View reviewed changes

Comment thread utilities/game.py

Comment thread utilities/game.py Outdated

Comment thread controllers/autoclimber.py Outdated

Comment thread utilities/game.py Outdated

Comment thread utilities/game.py Outdated

Comment thread utilities/game.py

This comment was marked as off-topic.

Sign in to view

DannyPomeranian force-pushed the make_auto_climb_logic branch from da1633e to 1b3c7a1 Compare March 5, 2026 08:22

thedropbears deleted a comment from greptile-apps Bot Mar 5, 2026

auscompgeek reviewed Mar 8, 2026

View reviewed changes

Comment thread controllers/autoclimber.py Outdated

Comment thread utilities/game.py

DannyPomeranian force-pushed the make_auto_climb_logic branch from d0cf526 to 46e33a7 Compare March 8, 2026 11:29

DannyPomeranian requested a review from auscompgeek March 8, 2026 11:30

auscompgeek reviewed Mar 8, 2026

View reviewed changes

Comment thread utilities/game.py

Comment thread utilities/game.py

Comment thread utilities/game.py

Comment thread utilities/game.py Outdated

LHowe-a11y force-pushed the make_auto_climb_logic branch 4 times, most recently from 6ac1dd2 to 3e1d271 Compare March 10, 2026 08:57

LHowe-a11y requested a review from auscompgeek March 10, 2026 09:04

auscompgeek reviewed Mar 10, 2026

View reviewed changes

LHowe-a11y force-pushed the make_auto_climb_logic branch from 81fc757 to ff201c1 Compare March 10, 2026 21:42

SyntaxBreak and others added 11 commits March 11, 2026 15:39

add autoclimber state machine and its dependencies

9ed6e7e

remove feedback, fix wrong axis, use state_tm for driving_into_tower

0cd80e3

change moving to tower to use closed loop

1c8eb98

rename retracting state to grounding

c3b9aa9

rework movement to tower to give a rotation2d and use a timed state i…

593da0c

…nstead of manual timing

connect autoclimber and auto_base as well as add dependencies

74e30e1

change logic in safing state to use new is_close_to_tower function

7e52039

clean up errors

371721a

fix coordinate system inversion in movement to tower

7c43f4f

consistent naming between auto_base and robotpy for climber state mac…

9830ab1

…hine

remove misleading comment

2a28c54

DannyPomeranian force-pushed the make_auto_climb_logic branch from ff201c1 to 2a28c54 Compare March 11, 2026 04:39

DannyPomeranian added 2 commits March 11, 2026 18:39

fix bugs and implement machine in test

35f500a

Merge branch 'main' into make_auto_climb_logic

7eb5215

		return Translation2d(FIELD_LENGTH - t.x, t.y)


		def rotational_flip_translation2d(t: Translation2d):

Conversation

SyntaxBreak commented Mar 1, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LucienMorey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DannyPomeranian commented Mar 3, 2026

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

auscompgeek commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DannyPomeranian commented Mar 5, 2026

Uh oh!

DannyPomeranian commented Mar 5, 2026

Uh oh!

DannyPomeranian commented Mar 5, 2026

Uh oh!

SyntaxBreak commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

auscompgeek Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

LHowe-a11y Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

auscompgeek Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

DannyPomeranian commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

auscompgeek commented Mar 5, 2026 •

edited

Loading

SyntaxBreak commented Mar 6, 2026 •

edited

Loading