Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bno055: Clean up and fix #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

auscompgeek
Copy link
Member

Apparently our BNO055.getHeadingRate() has been broken this entire time.
We also had roll and pitch the wrong way around according to the
datasheet, but at least we weren't reading those anyway.

@codecov
Copy link

codecov bot commented Mar 9, 2018

Codecov Report

Merging #27 into master will increase coverage by 0.21%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage    82.6%   82.81%   +0.21%     
==========================================
  Files          19       19              
  Lines        1604     1618      +14     
  Branches      168      165       -3     
==========================================
+ Hits         1325     1340      +15     
  Misses        228      228              
+ Partials       51       50       -1
Impacted Files Coverage Δ
utilities/bno055_sim.py 89.47% <100%> (ø) ⬆️
utilities/bno055.py 94.21% <94.52%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adb6362...f64a6d2. Read the comment docs.

@james-ward
Copy link
Contributor

Surely the yaw rate is around the z-axis?

@auscompgeek
Copy link
Member Author

IIRC, the BNO055 data sheet defines the X axis as the heading/yaw. I'll double-check again, but given the order of the registers, it makes sense.

Apparently our BNO055.getHeadingRate() has been broken this entire time.
We also had roll and pitch the wrong way around according to the
datasheet, but at least we weren't reading those anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants